CASSANDRA-18511 Add support for JMX in the in-jvm dtest framework (4.1) #2328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeetKunDoug
force-pushed
the
jmx-in-jvm-dtest-4.1
branch
from
e5461b7 to
ab336f9
Compare
JeetKunDoug
changed the title
JeetKunDoug
force-pushed
the
jmx-in-jvm-dtest-4.1
branch
3 times, most recently
from
925158c to
6ee3142
Compare
… without blind Thread.sleep calls. - Clean up unnecessary modifiers in MBeanWrapper (interface members don't need public, static, or final modifiers)
JeetKunDoug
force-pushed
the
jmx-in-jvm-dtest-4.1
branch
3 times, most recently
from
66f5ea6 to
5101cce
Compare
…ts in JMX. Additionally, added the ability to run some code in the looper tests that's passed from the test itself so that it can better exercise functionality.
JeetKunDoug
force-pushed
the
jmx-in-jvm-dtest-4.1
branch
from
5101cce to
d9b98a3
Compare
jonmeredith
reviewed
May 22, 2023
| import org.apache.cassandra.utils.concurrent.Ref; | ||
| import org.apache.cassandra.utils.memory.BufferPools; | ||
| import org.apache.cassandra.utils.progress.jmx.JMXBroadcastExecutor; | ||
| import sun.rmi.transport.tcp.TCPEndpoint; |
Contributor
There was a problem hiding this comment.
should probably be up top after slf4j
JeetKunDoug
force-pushed
the
jmx-in-jvm-dtest-4.1
branch
from
9f3e983 to
2b08bff
Compare
JeetKunDoug
force-pushed
the
jmx-in-jvm-dtest-4.1
branch
from
321d724 to
5e65344
Compare
jonmeredith
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.