fix Segment#intersects to compare bound instead of token #2416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maedhroz
reviewed
Jun 14, 2023
src/java/org/apache/cassandra/index/sai/disk/v1/segment/Segment.java
Outdated
Show resolved
Hide resolved
maedhroz
reviewed
Jun 14, 2023
Contributor
There was a problem hiding this comment.
With the changes in this method, we no longer need the minKey or maxKey fields in this class, right?
Contributor
Author
There was a problem hiding this comment.
removed minKey and maxKey
maedhroz
reviewed
Jun 14, 2023
src/java/org/apache/cassandra/index/sai/disk/v1/segment/Segment.java
Outdated
Show resolved
Hide resolved
maedhroz
requested changes
Jun 14, 2023
Contributor
maedhroz
left a comment
maedhroz
left a comment
There was a problem hiding this comment.
@jasonstack Mostly looks good. Just a few little things to clean up as a result of the changes...
maedhroz
approved these changes
Jun 15, 2023
jasonstack
force-pushed
the
fix-segment-intersects
branch
from
11d1838 to
a43053a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.