Skip to content

Conversation

@smiklosovic
Copy link
Contributor

patch by Stefan Miklosovic; reviewed by TBD for CASSANDRA-18912

Thanks for sending a pull request! Here are some tips if you're new here:

  • Ensure you have added or run the appropriate tests for your PR.
  • Be sure to keep the PR description updated to reflect all changes.
  • Write your PR title to summarize what this PR proposes.
  • If possible, provide a concise example to reproduce the issue for a faster review.
  • Read our contributor guidelines
  • If you're making a documentation change, see our guide to documentation contribution

Commit messages should follow the following format:

<One sentence description, usually Jira title or CHANGES.txt summary>

<Optional lengthier description (context on patch)>

patch by <Authors>; reviewed by <Reviewers> for CASSANDRA-#####

Co-authored-by: Name1 <email1>
Co-authored-by: Name2 <email2>

The Cassandra Jira

vgali7 and others added 30 commits August 7, 2023 12:19
patch by Vineet Gali; reviewed by Stefan Miklosovic and Brandon Williams for CASSANDRA-18726
* cassandra-5.0:
  Disable heap dump creation by default on crash for tests that use test/conf/cassandra.yaml
* cassandra-5.0:
  Update trunk to version 5.1
* cassandra-5.0:
  ninjafix debian changelog (CASSANDRA-18705)
* cassandra-5.0:
  Add CASSANDRA-14227 to 5.0 new features page
* cassandra-5.0:
  Reduce size of per-SSTable index components for SAI
@Mmuzaf
Copy link
Contributor

Mmuzaf commented Oct 10, 2023

I've looked through all the changes, and they look good. I haven't checked the exact numbers for each deprecated annotation yet. I'll do it soon.

I was thinking about adding a new checktyle rule that forces having the "since" element for every @Deprecated annotation, and I couldn't find a good solution here. Do you have anything good in mind for this case?

After struggling with this for an hour, I've submitted a ticket for that to the checkstyle project:
checkstyle/checkstyle#13864

dcapwell and others added 6 commits October 10, 2023 14:20
* cassandra-5.0:
  ninja-fix remove all DSE references
* cassandra-5.0:
  Test failure: org.apache.cassandra.tools.nodetool.ForceCompactionTest.forceCompactMultipleRowsTombstoneTest-.jdk11
* cassandra-5.0:
  Fixes for in-tree scripts: offline mode, maybe-build for fqltool-test, jvm-dtest-upgrade
* cassandra-5.0:
  ninja-fix – reusing git clone under build needs reset and permissions
@smiklosovic smiklosovic force-pushed the CASSANDRA-18912 branch 2 times, most recently from 7ec806d to 7da5735 Compare October 17, 2023 10:58
smiklosovic and others added 3 commits October 18, 2023 12:58
patch by Stefan Miklosovic; reviewed by TBD for CASSANDRA-18912

Co-authored-by: Maxim Muzafarov <maxmuzaf@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.