Remove completed coordinator sessions #2813
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maedhroz
reviewed
Oct 19, 2023
src/java/org/apache/cassandra/repair/consistent/CoordinatorSession.java
Outdated
Show resolved
Hide resolved
maedhroz
reviewed
Oct 19, 2023
src/java/org/apache/cassandra/repair/consistent/ConsistentSession.java
Outdated
Show resolved
Hide resolved
maedhroz
reviewed
Oct 19, 2023
Contributor
There was a problem hiding this comment.
nit: Any way we could just call into node 1 and get the number of sessions via ARS rather than having to check the logs? If that's brutal, no biggie, but I don't even thing we'd have to change the visibility of anything, and we already have the UUID?
Contributor
Author
There was a problem hiding this comment.
Talked about this with Caleb - I actually prefer the logs check because it's more explicit than "nothing found in map" - it confirms that the specific action (removal from ARS.consistent.coordinated) was taken, rather than the more generic "no data found".
maedhroz
approved these changes
Oct 19, 2023
aratno
force-pushed
the
CASSANDRA-18903-repair-consistent-leak-4.0
branch
from
e1e24e0 to
14f9a00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CASSANDRA-18903