Skip to content

Conversation

@yifan-c
Copy link
Contributor

@yifan-c yifan-c commented Oct 25, 2023

Thanks for sending a pull request! Here are some tips if you're new here:

  • Ensure you have added or run the appropriate tests for your PR.
  • Be sure to keep the PR description updated to reflect all changes.
  • Write your PR title to summarize what this PR proposes.
  • If possible, provide a concise example to reproduce the issue for a faster review.
  • Read our contributor guidelines
  • If you're making a documentation change, see our guide to documentation contribution

Commit messages should follow the following format:

<One sentence description, usually Jira title or CHANGES.txt summary>

<Optional lengthier description (context on patch)>

patch by <Authors>; reviewed by <Reviewers> for CASSANDRA-#####

Co-authored-by: Name1 <email1>
Co-authored-by: Name2 <email2>

The Cassandra Jira

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code format , "which" and "to" should align "A" like the pr for trunk

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code format : "." align, seems not same with the pr for trunk

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code format

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code format

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code format

@yifan-c
Copy link
Contributor Author

yifan-c commented Nov 2, 2023

Thanks @Maxwell-Guo for spotting those! I am pushing a new commit to update and will check the other PRs too.

@yifan-c yifan-c force-pushed the CASSANDRA-18941/cassandra-4.0 branch from 100a46f to d5336a8 Compare November 2, 2023 17:04
@yifan-c yifan-c closed this Dec 5, 2023
@yifan-c
Copy link
Contributor Author

yifan-c commented Dec 5, 2023

Closed the committed patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants