Allow unhandled operators on SAI indexed columns #2865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-tr-adamson
changed the title
Allow operators not handled by an SAI index to be handled by post-filtering using ALLOW FILTERING patch by Mike Adamson; reviewed by <reviewers> for CASSANDRA-18994
mike-tr-adamson
force-pushed
the
CASSANDRA-18994-trunk
branch
from
59ef414 to
dd738e8
Compare
Maxwell-Guo
reviewed
Nov 7, 2023
| for (final RowFilter.Expression e : expressions) | ||
| { | ||
| IndexContext indexContext = controller.getContext(e); | ||
|
|
| } | ||
|
|
||
| assert operator != null; | ||
| assert operator != null || context.isNotIndexed() : "Cannot use '" + op + "' operator with indexed " + context.getColumnName() + " column"; |
Contributor
There was a problem hiding this comment.
what about also give the output with table name and sai index name ?
| public class UnhandledExpressionsTest extends SAITester | ||
| { | ||
| @Test | ||
| public void unhandledOperatorsOnIndexedColumnAreHandledCorrectly() |
Contributor
There was a problem hiding this comment.
I think the function name is too long , what about change to some thing like this: testUnHandledOperatorsOnSaiIndex, and we can give some detailed description in the function body to show what the cases are(which you have done).
belliottsmith
force-pushed
the
trunk
branch
2 times, most recently
from
df3eb40 to
54e39a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for sending a pull request! Here are some tips if you're new here:
Commit messages should follow the following format:
The Cassandra Jira