CASSANDRA-19637(trunk): Makes conditions behavior on frozen and non-frozen columns consistent for null column values #3362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patch by Benedict Elliott Smith; review by Blake Eggleston for CASSANDRA-19617
blerer
force-pushed
the
CASSANDRA-19617-trunk
branch
from
6a2cb4b to
1d310ee
Compare
dcapwell
reviewed
Jun 11, 2024
| @@ -1,3 +1,4 @@ | |||
| <<<<<<< HEAD | |||
dcapwell
reviewed
Jun 11, 2024
| return open(table.keyspace).getColumnFamilyStore(table.id); | ||
| } | ||
|
|
||
| public static ColumnFamilyStore openAndGetStoreIfExists(TableMetadata table) |
dcapwell
reviewed
Jun 11, 2024
| * Returns a ColumnFamilyStore by metadata if it exists, null otherwise | ||
| * Differently from others, this method does not throw exception if the table does not exist. | ||
| */ | ||
| public static ColumnFamilyStore getIfExists(TableMetadata table) |
dcapwell
reviewed
Jun 11, 2024
| return cfs; | ||
| } | ||
|
|
||
| public ColumnFamilyStore getIfExists(TableId id) |
dcapwell
reviewed
Jun 11, 2024
Contributor
dcapwell
left a comment
dcapwell
left a comment
There was a problem hiding this comment.
don't know paxos well enough to comment that the changes are correct and safe, so would need someone like @belliottsmith to review that section. The rest of the changes LGTM though
Contributor
Author
|
@dcapwell Looking at the PR I mixed up 2 patches here. Let me clean my mess. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for sending a pull request! Here are some tips if you're new here:
Commit messages should follow the following format:
The Cassandra Jira