CASS-20015: Add -H option in the nodetool compactionhistory#3628
Closed
chengw-netflix wants to merge 1 commit intoapache:trunkfrom
Closed
CASS-20015: Add -H option in the nodetool compactionhistory#3628chengw-netflix wants to merge 1 commit intoapache:trunkfrom
chengw-netflix wants to merge 1 commit intoapache:trunkfrom
Conversation
smiklosovic
reviewed
Oct 24, 2024
src/java/org/apache/cassandra/tools/nodetool/stats/CompactionHistoryHolder.java
Outdated
Show resolved
Hide resolved
smiklosovic
reviewed
Oct 24, 2024
src/java/org/apache/cassandra/tools/nodetool/stats/CompactionHistoryHolder.java
Outdated
Show resolved
Hide resolved
smiklosovic
reviewed
Oct 24, 2024
src/java/org/apache/cassandra/tools/nodetool/stats/CompactionHistoryHolder.java
Outdated
Show resolved
Hide resolved
smiklosovic
reviewed
Oct 24, 2024
src/java/org/apache/cassandra/tools/nodetool/stats/CompactionHistoryPrinter.java
Outdated
Show resolved
Hide resolved
8f4c656 to
31706c9
Compare
31706c9 to
b54f714
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a -H option to the nodetool compactionhistory command Cassandra. The -H option formats the output in a human-readable manner, making it easier for users to interpret the data.
More specifically, when the -H option is used, the bytes_in and bytes_out fields are displayed in a more readable format (e.g., KiB).
Testing