Suggested fixes by iCR, OpenRefactory, Inc.

[openrefactory]

OpenRefactory introduces fixers, that automatically fix safety, security, reliability and compliance issues. We ran OpenRefactory's Intelligent Code Repair (iCR) analysis engine on your code. We are reporting a few sample fixes that were generated.
The goal of the this fix is to resolve Zero Division Check, Unexpected Control Flow and Weak Library Usage problem.

Zero Division Check Fixes:

In file: Duration.java, class: Duration, method: append , there is a potential Division By Zero error while running. iCR suggested changes in 1 files to resolve the problem.

In file: CommitLog.java, class: CommitLog, method: getActiveSegmentCompressionRatios , there is a potential Division By Zero error while running. iCR suggested changes in 1 files to resolve the problem.

In file: SizeTieredCompactionStrategy.java, class: SizeTieredCompactionStrategy, method: getEstimatedCompactionsByTasks , there is a potential Division By Zero error while running. iCR suggested changes in 1 files to resolve the problem.

In file: Upgrader.java, class: Upgrader, method: Upgrader, there is a potential Division By Zero error while running. iCR suggested changes in 1 files to resolve the problem.

In file: MajorLeveledCompactionWriter.java, class: MajorLeveledCompactionWriter, method: MajorLeveledCompactionWriter, there is a potential Division By Zero error while running. iCR suggested changes in 1 files to resolve the problem.

In file: MaxSSTableSizeWriter.java, class: MaxSSTableSizeWriter, method: MaxSSTableSizeWriter , there is a potential Division By Zero error while running. iCR suggested changes in 1 files to resolve the problem.

In file: StorageProxy.java, class: StorageProxy, method: estimateResultsPerRange , there is a potential Division By Zero error while running. iCR suggested changes in 1 files to resolve the problem.

The fix addresses CWE 369

Unexpected Control Flow Fixes:

In file: AbstractTypeVersionComparator.java, class: AbstractTypeVersionComparator, method: compareCompositeTypes has a semicolon at an unusual place . iCR suggested changes in 1 files to resolve the problem.

Weak Library Usage Fixes:

In file: UUIDGen.java, class: UUIDGen, method:hash uses Random object but it may not be truly random. It should be replaced with SecureRandom. . iCR suggested changes in 1 files to resolve the problem.

[smiklosovic]

Please file a JIRA ticket in Apache JIRA if you want to make this happen first. Thank you.