Skip to content

CASSANDRA-20101 Disable repair on system_traces.* tables by default#3705

Closed
jaydeepkumar1984 wants to merge 59 commits intoapache:trunkfrom
jaydeepkumar1984:trunk_cep_37_cassandra_20101
Closed

CASSANDRA-20101 Disable repair on system_traces.* tables by default#3705
jaydeepkumar1984 wants to merge 59 commits intoapache:trunkfrom
jaydeepkumar1984:trunk_cep_37_cassandra_20101

Conversation

@jaydeepkumar1984
Copy link
Contributor

@jaydeepkumar1984 jaydeepkumar1984 commented Nov 21, 2024

Thanks for sending a pull request! Here are some tips if you're new here:

  • Ensure you have added or run the appropriate tests for your PR.
  • Be sure to keep the PR description updated to reflect all changes.
  • Write your PR title to summarize what this PR proposes.
  • If possible, provide a concise example to reproduce the issue for a faster review.
  • Read our contributor guidelines
  • If you're making a documentation change, see our guide to documentation contribution

Commit messages should follow the following format:

<One sentence description, usually Jira title or CHANGES.txt summary>

<Optional lengthier description (context on patch)>

patch by <Authors>; reviewed by <Reviewers> for CASSANDRA-#####

Co-authored-by: Name1 <email1>
Co-authored-by: Name2 <email2>

The Cassandra Jira

jaydeepkumar1984 and others added 30 commits November 5, 2024 17:45
@jaydeepkumar1984 @jaydeep1984
autorepair v2 framework
7fe3853
@jaydeepkumar1984 @jaydeep1984
cr
c849deb
@jaydeepkumar1984 @jaydeep1984
chop the repair API
ca1891f
@kzalys @jaydeep1984
Add a test case that ensures LocalStrategy.class is ignored from bein…
3ad85dd 
…g repaired
@kzalys @jaydeep1984
Shuffle keyspaces and tables when running auto-repair
060e390
@kzalys @jaydeep1984
Prevent node restart from scheduling a premature auto-repair cycle
3dcebe6
@kzalys @jaydeep1984
Implement SucceededTokenRangesCount and FailedTokenRangesCount metric…
dd54c74 
…s for auto-repair
@kzalys @jaydeep1984
Add intial_scheduler_delay option to AutoRepairConfig
d1501fa
@kzalys @jaydeep1984
Implement nodetool sstablerepairedset
50110b6
@kzalys @jaydeep1984
Change SkippedTablesCount metric to SkippedTokenRangesCount
cfc6bde
@jaydeepkumar1984 @jaydeep1984
config description
0271718
@kzalys @jaydeep1984
Implement repair retries for auto-repair scheduler
99acef9
@kzalys @jaydeep1984
Extend nodetool sstablerepairedset to affect all keyspaces when no ke…
b071c59 
…yspace is provided in args
@jaydeepkumar1984 @jaydeep1984
Make repair session timeout configurable
4e4485f
@jaydeepkumar1984 @jaydeep1984
Comments from Joshua M
f51a1ef
@jaydeepkumar1984 @jaydeep1984
AutoRepair scheduler InJvm dtest
095d321
@jaydeepkumar1984 @jaydeep1984
Increase CircleCI parallelism 1-->4
0ac15d9
@jaydeepkumar1984 @jaydeep1984
Fix a test case failure org.apache.cassandra.schema.SchemaKeyspaceTes…
b39b58f 
…t::testConversionsInverses
@jaydeepkumar1984 @jaydeep1984
Trigger automatic CircleCI jobs
f69d7d7
@jaydeepkumar1984 @jaydeep1984
CircleCI ask for a manual approval
461f18a
@kzalys @jaydeep1984
Fix the JMXStandardsTest::interfaces
4b58140
@jaydeep1984
Circle AutoStart J8 tests
91911b4
@kzalys @jaydeep1984
Allow IR to run with MVs and CDC if write path replay is disabled
938d8d3
@kzalys @jaydeep1984
Add a nodetool command to get the nodes going through repair
8a348d7
@jaydeepkumar1984 @jaydeep1984
Adjust a couple of default configuration values
2c200a8
@jaydeepkumar1984 @jaydeep1984
Rename EMPTY --> NONE for Nodetool autorepairstatus command
1648097
@jaydeepkumar1984 @jaydeep1984
Minor code refactoring to simplify the repair API by removing the SLE…
0881ee7 
…EP_IF_REPAIR_FINISHES_QUICKLY
@jaydeepkumar1984 @jaydeep1984
Adjust AutoRepair on 5.0
9040b9c
@jaydeepkumar1984 @jaydeep1984
Fix unit test cases DescribeStatementTest & SchemaCQLHelperTest
08ec734
@jaydeepkumar1984 @jaydeep1984
Safeguard the setup call to ensure it it done only once
6d30102
jaydeepkumar1984 and others added 28 commits November 14, 2024 16:55
@jaydeepkumar1984 @jaydeep1984
Unit test failures AutoRepairTest.java
a5cdd4f
@jaydeepkumar1984 @jaydeep1984
5.0 formatting
5ed34ea
@jaydeepkumar1984 @jaydeep1984
Fix flaky AutoRepairTest::testSetup and AutoRepairTest::testSafeGuard…
ff50053 
…SetupCall
@kzalys @jaydeep1984
Fix a test failure inside pylib/cqlshlib/test/test_cqlsh_output.py
82733d7
@jaydeepkumar1984 @jaydeep1984
AutoRepair nodetool throws an exception if the framework is disabled
8c6d17c
@jaydeepkumar1984 @jaydeep1984
Run repair on bootstrapped if configured to do so
df5b922
@jaydeepkumar1984 @jaydeep1984
Fix broken AutoRepairSchedulerTest.java & AutoRepairStatusTest.java
242d082
@jaydeepkumar1984 @jaydeep1984
Comments from Chris Lohfink: nix automated_ and a typo
819771f
@jaydeepkumar1984 @jaydeep1984
Comments from Chris Lohfink: System::currentTimeMillis --> Clock.Glob…
0cf7a57 
…al::currentTimeMillis
@tolbertam @jaydeep1984
Update IAutoRepairTokenRangeSplitter API to be more flexible
5828bc9 
Updates IAutoRepairTokenRangeSplitter API to take in a set of tables
instead of a single table and return "RepairAssignments".

This allows the API more control over how the repairs are issued by
the AutoRepair framework, by allowing grouping of repairs by specific
tables or a single repair at the keyspace level.

Also updates IAutoRepairTokenRangeSplitter to be a ParameterizedClass,
so custom splitters can have their own configuration.

Update AutoRepair to account for these changes.

Update DefaultAutoRepairTokenSplitter to account for the change, and
to also evaluate on getRepairByKeyspace option.  This also improves
the filtering of tables that should not be repaired where previously
getRepairByKeyspace would not factor this in.

Move logic to split token ranges evenly into AutoRepairUtils so it
can be reutilized by other splitters.
@jaydeepkumar1984 @jaydeep1984
Fix a corner-case bug NPE org.apache.cassandra.repair.autorepair.Auto…
a69a71a 
…RepairUtils.myTurnToRunRepair
@jaydeepkumar1984 @jaydeep1984
Update documentation for the newly added metric
d58dc73
@jaydeepkumar1984 @jaydeep1984
Fix the failed StorageServiceServerTest test cases
d214ad6
@jaydeepkumar1984 @jaydeep1984
Formatting: Add a new line towards the end SystemDistributedKeyspace.…
c641fd4 
…java
@jaydeepkumar1984 @jaydeep1984
Formatting: Add a new line towards the end IAutoRepairTokenRangeSplit…
e340bac 
…ter.java
@jaydeepkumar1984 @jaydeep1984
Formatting: YamlConfigurationLoader.java & CassandraStreamReceiver.java
2c007e0
@jaydeepkumar1984 @jaydeep1984
Revert .circleci/config.yaml settings
a8fb1aa
@jaydeepkumar1984 @jaydeep1984
Code formatting: Remove Group from naming
c984d46
@jaydeepkumar1984 @jaydeep1984
Enable repair scheduler through nodetool
ab452a6
@jaydeepkumar1984 @jaydeep1984
Increment system_distributed GENERATION
e1357c1
@jaydeepkumar1984 @jaydeep1984
Option to disable write path during streaming for MV enabled tables; …
793683d 
…similar to CASSANDRA-17666
@jaydeepkumar1984 @jaydeep1984
cr from tolbertam - replace MV/CDC repair replay JVM properties to ya…
c888f73 
…ml configs
@jaydeepkumar1984 @jaydeep1984
code formatting for StreamOperation.java
206637c
@jaydeepkumar1984 @jaydeep1984
ant checkstyle: toLowerCase-->toLowerCaseLocalized
5fa4015
@jaydeepkumar1984 @jaydeep1984
code formatting: DatabaseDescriptor.java
c6bd7df
@jaydeepkumar1984 @jaydeep1984
Rename AutoRepair --> UnifiedRepair
f9f6971
@jaydeep1984
Revert "Rename AutoRepair --> UnifiedRepair"
5c7f394 
This reverts commit f9f6971.
@jaydeepkumar1984 @jaydeep1984
Disable FR and IR by default on system_traces.* tables
862aa27
@jaydeepkumar1984 jaydeepkumar1984 changed the title Trunk cep 37 cassandra 20101 CASSANDRA-20101 Disable repair on system_traces.* tables by default Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jaydeepkumar1984 @kzalys @jaydeep1984 @tolbertam