CASSANDRA-20422: improve the golang download when building source code#3966
Closed
maoling wants to merge 1 commit intoapache:trunkfrom
Closed
CASSANDRA-20422: improve the golang download when building source code#3966maoling wants to merge 1 commit intoapache:trunkfrom
maoling wants to merge 1 commit intoapache:trunkfrom
Conversation
Member
maoling
commented
Mar 9, 2025
- more details in the CASSANDRA-20422
michaelsembwever
approved these changes
Mar 10, 2025
Member
michaelsembwever
left a comment
There was a problem hiding this comment.
LGTM, two small nits.
smiklosovic
reviewed
Mar 10, 2025
Contributor
There was a problem hiding this comment.
@maoling if this fails because e.g. we are genuinely offline (e.g. in an airplane / train), then this will echo network issue but it will keep executing the rest of the code. But if it was not downloaded, then tar -C ... fails because TMPDIR/GO_TAR does not exist etc. We should fail in a more graceful manner.
Member
There was a problem hiding this comment.
both should fail hard.
if there's no network we can output that offline only works with go manually installed (or if you use -Dant.gen-doc.skip=true)
725c926 to
e897bd5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.