Skip to content

CASSANDRA-20422: improve the golang download when building source code#3966

Closed
maoling wants to merge 1 commit intoapache:trunkfrom
maoling:CASSANDRA-20422
Closed

CASSANDRA-20422: improve the golang download when building source code#3966
maoling wants to merge 1 commit intoapache:trunkfrom
maoling:CASSANDRA-20422

Conversation

@maoling
Copy link
Member

@maoling maoling commented Mar 9, 2025

Copy link
Member

@michaelsembwever michaelsembwever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, two small nits.

Copy link
Contributor

@smiklosovic smiklosovic Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maoling if this fails because e.g. we are genuinely offline (e.g. in an airplane / train), then this will echo network issue but it will keep executing the rest of the code. But if it was not downloaded, then tar -C ... fails because TMPDIR/GO_TAR does not exist etc. We should fail in a more graceful manner.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both should fail hard.

if there's no network we can output that offline only works with go manually installed (or if you use -Dant.gen-doc.skip=true)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants