Closed
Conversation
Sync Fork January 6
yifan-c
reviewed
Jan 29, 2020
yifan-c
reviewed
Jan 29, 2020
yifan-c
reviewed
Jan 29, 2020
yifan-c
reviewed
Jan 30, 2020
yifan-c
reviewed
Jan 30, 2020
doc/source/new/fqllogging.rst
Outdated
Contributor
There was a problem hiding this comment.
This should be sitting together with the one regarding batch query attributes above.
yifan-c
reviewed
Jan 30, 2020
doc/source/new/fqllogging.rst
Outdated
Contributor
There was a problem hiding this comment.
The introduction of the weighted queue is too detailed (especially the exceptions, the unit tests, etc.) that I feel only Cassandra developer will be interested in. Could we have a high-level introduction about the weighted queue, and move the details into a quoted note section for developers?
yifan-c
reviewed
Jan 30, 2020
doc/source/new/fqllogging.rst
Outdated
Contributor
There was a problem hiding this comment.
The format is not consistent with batch query attributes. Please unify
FieldName - Description
yifan-c
reviewed
Jan 30, 2020
| :: | ||
|
|
||
| sudo mkdir -p /tmp/cassandrafullquerylog | ||
| sudo chmod -R 777 /tmp/cassandrafullquerylog |
Contributor
There was a problem hiding this comment.
Why 777? No files are expected to be executed.
yifan-c
reviewed
Jan 30, 2020
| Query: SELECT * FROM system.peers | ||
| Values: | ||
|
|
||
| Type: single-query |
Contributor
There was a problem hiding this comment.
Can we truncate the entries? It makes the page unnecessarily long.
yifan-c
reviewed
Jan 31, 2020
Contributor
yifan-c
left a comment
yifan-c
left a comment
There was a problem hiding this comment.
Appreciate the efforts on making those improvements!
If possible, please further reduce the dumped content from the cq4 file.
Contributor
Author
|
yifan-c
reviewed
Feb 4, 2020
Member
|
This has been committed. |
blambov
pushed a commit
to blambov/cassandra
that referenced
this pull request
Jun 13, 2022
* STAR-1230 Provide CL API to update to remote storage Extends CommitLog's API to allow update its directory, so a commit log from remote storage can be replayed. * Add test of CL's forPath * Fix test method name (cherry picked from commit 17a0558)
adelapena
pushed a commit
to adelapena/cassandra
that referenced
this pull request
Sep 26, 2023
* STAR-1230 Provide CL API to update to remote storage Extends CommitLog's API to allow update its directory, so a commit log from remote storage can be replayed. * Add test of CL's forPath * Fix test method name (cherry picked from commit 17a0558) (cherry picked from commit 241c971) (cherry picked from commit 33cb1c6) (cherry picked from commit c47530b)
ekaterinadimitrova2
pushed a commit
to ekaterinadimitrova2/cassandra
that referenced
this pull request
Jun 3, 2024
* STAR-1230 Provide CL API to update to remote storage Extends CommitLog's API to allow update its directory, so a commit log from remote storage can be replayed. * Add test of CL's forPath * Fix test method name (cherry picked from commit 17a0558) (cherry picked from commit 241c971) (cherry picked from commit 33cb1c6) (cherry picked from commit c47530b) (cherry picked from commit c56b818)
michaelsembwever
pushed a commit
to thelastpickle/cassandra
that referenced
this pull request
Jan 7, 2026
* STAR-1230 Provide CL API to update to remote storage Extends CommitLog's API to allow update its directory, so a commit log from remote storage can be replayed. * Add test of CL's forPath * Fix test method name (cherry picked from commit 17a0558) (cherry picked from commit 241c971) (cherry picked from commit 33cb1c6) (cherry picked from commit c47530b) (cherry picked from commit c56b818)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a page on Full Query Logging, a new feature.