More accord metrics #4466
Merged
More accord metrics #4466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belliottsmith
force-pushed
the
more-accord-metrics
branch
4 times, most recently
from
c2f71a2 to
36c8733
Compare
ifesdjeen
approved these changes
Nov 13, 2025
Contributor
ifesdjeen
left a comment
ifesdjeen
left a comment
There was a problem hiding this comment.
+1
the only question i have remaining is whether 0th percentile is meaningless.
in general, i am wondering if this holds:
@Override
public double getValue(double quantile)
{
return get((long)Math.ceil(totalCount * quantile));
}
should we find min/max and then compute percentile indices based on those?
| { | ||
| return Serialize.fromBytes(key, (ByteBuffer)shrunk); | ||
| ByteBuffer bb = (ByteBuffer)shrunk; | ||
| bb.position(prefixBytes(bb)); |
Contributor
There was a problem hiding this comment.
Should we duplicate here maybe?
Contributor
Author
There was a problem hiding this comment.
yep, good idea. we should be discarding it, but better safe than sorry and can do it without any net cost by skipping the internal duplicate
| Timestamp trxTimestamp = cmd.txnId(); | ||
| metrics.preapplyLatency.update(now - trxTimestamp.hlc(), TimeUnit.MICROSECONDS); | ||
| long elapsed = elapsed(cmd.txnId()); | ||
| System.err.println("Recording preapply latency of " + elapsed + " for " + cmd.txnId()); |
Contributor
There was a problem hiding this comment.
nit: should this be trace?
Contributor
Author
There was a problem hiding this comment.
ah, whoops. sorry this was debugging
Contributor
Author
|
I've pushed improvements to getMin, getMax and getPercentile(0d) |
ifesdjeen
approved these changes
Nov 13, 2025
belliottsmith
force-pushed
the
more-accord-metrics
branch
5 times, most recently
from
7c9143a to
2ce1eaa
Compare
Also Introduce: - Sharded/LogLinearDecayingHistogram Also Improve: - Do not take a reference to CFK unless relevant Also Fix: - Sharded/LogLinearHistogram - ExecuteFlags serialization bug in ReadData patch by Benedict; reviewed by Alex Petrov for CASSANDRA-21017
belliottsmith
force-pushed
the
more-accord-metrics
branch
from
2ce1eaa to
d5243a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for sending a pull request! Here are some tips if you're new here:
Commit messages should follow the following format:
The Cassandra Jira