Check if webbrowser._tryorder is not None for python 3 #448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dineshjoshi
requested changes
Feb 17, 2020
| # >>> webbrowser._browser | ||
| # | ||
| if len(webbrowser._tryorder) == 0: | ||
| if webbrowser._tryorder is None or len(webbrowser._tryorder) == 0: |
Member
There was a problem hiding this comment.
Can you just call webbrowser.get() and leave the rest of the code as-is? This will initialize the _tryorder variable.
Contributor
There was a problem hiding this comment.
in a Docker testing environment it's likely that no default browser is installed and so you could end up in https://github.com/python/cpython/blob/3.7/Lib/webbrowser.py#L65, so I'm +1 with the fix here
Contributor
Author
There was a problem hiding this comment.
I tried webbroser.get() and ran in docker container, and I hit the error mentioned. So I think it is safer to check if it is None.
Contributor
|
Is this still relevant? Looks like the relevant code on If no longer relevant, can you please close this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.