Improve CMS initialization with DOWN nodes#4486
Closed
beobal wants to merge 1 commit intoapache:trunkfrom
Closed
Conversation
Contributor
beobal
commented
Nov 20, 2025
beobal
commented
- Test that aborted CMS initialization cleans up state properly
- Unconditionally reset initiator during abort
- Ensure that metadata log entries aren't exchanged before CMS initialization is complete
- Precalculate common serialization version, excluding non-upgraded and LEFT nodes
- Add metadata identifier to nodetool cms output
beobal
force-pushed
the
samt/CASSANDRA-21036
branch
from
b2f9cd5 to
de5faec
Compare
* Better handling of DOWN unupgraded nodes * Test that aborted CMS initialization cleans up state properly * Clean up orphaned PreInitialize entries in the log on bounce * Unconditionally reset initiator during abort * Ensure that metadata log entries aren't exchanged before CMS initialization is complete * Precalculate common serialization version, excluding non-upgraded and LEFT nodes * Decide if metadata-impacting upgrade is in progress using min common version * Add metadata identifier to nodetool cms output Patch by Sam Tunnicliffe and Marcus Eriksson; reviewed by Sam Tunnicliffe and Marcus Eriksson for CASSANDRA-21036 Co-authored-by: Marcus Eriksson <marcuse@apache.org> Co-authored-by: Sam Tunnicliffe <samt@apache.org>
beobal
force-pushed
the
samt/CASSANDRA-21036
branch
from
de5faec to
292b5cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.