[CASSANDRA-21166] Avoid creating of thousands of threads by MatcherResponse when many messages are handled using MockMessagingSpy#4624
Closed
netudima wants to merge 1 commit intoapache:trunkfrom
Closed
Conversation
driftx
requested changes
Feb 18, 2026
Contributor
driftx
left a comment
driftx
left a comment
There was a problem hiding this comment.
Mostly looks good, left some comments around using an ExecutorService.
driftx
approved these changes
Feb 18, 2026
…when many messages are handled using MockMessagingSpy Too many threads can lead to OOM, so new Thread is replaced ith an executor spin wait is added to HintsServiceTest.testPageSeek to avoid NPE (HintsStore is populated in an async way) patch by Dmitry Konstantinov; reviewed by Brandon Williams for CASSANDRA-21166
netudima
force-pushed
the
CASSANDRA-21166-trunk
branch
from
2587b47 to
25e2258
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid creating of thousands of threads by MatcherResponse when many messages are handled using MockMessagingSpy
Too many threads can lead to OOM, so new Thread is replaced with an executor; spinUntilTrue is added to HintsServiceTest.testPageSeek to avoid NPE (HintsStore is populated in an async way)
patch by Dmitry Konstantinov; reviewed by TBD for CASSANDRA-21166