[CASSANDRA-21152][trunk] Fix a removed TTLed row re-appearance in a materialized view after a cursor compaction#4697
Closed
netudima wants to merge 1 commit into
Closed
Conversation
netudima
force-pushed
the
CASSANDRA-21152-trunk
branch
from
3c7e197 to
3ac0c36
Compare
nitsanw
approved these changes
Mar 30, 2026
Contributor
nitsanw
left a comment
nitsanw
left a comment
There was a problem hiding this comment.
LGTM. Fix is correct, but I would suggest going further and removing the default implementation and making it a clear requirement for subclasses to implement (i.e. move the default to the Immutable case).
blambov
approved these changes
Apr 1, 2026
…cursor compaction Add an implementation of isExpired to ReusableLivenessInfo, before the change the method implementation was interited from an interface and always returned false, so livenessInfo().supersedes(...) did not work properly. patch by Dmitry Konstantinov; reviewed by Branimir Lambov, Nitsan Wakart for CASSANDRA-21152
netudima
force-pushed
the
CASSANDRA-21152-trunk
branch
from
a8e1667 to
241f207
Compare
Contributor
Author
|
Committed as 1a9ab95 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a removed TTLed row re-appearance in a materialized view after a cursor compaction
Add an implementation of isExpired to ReusableLivenessInfo, before the change the method implementation was interited from an interface and always returned false, so livenessInfo().supersedes(...) did not work properly.
patch by Dmitry Konstantinov; reviewed by TBD for CASSANDRA-21152