Fix MutationId class hierarchy and related maps lookup issues#4802
Merged
Conversation
patch by Aleksey Yeschenko; reviewed by Ariel Weisberg for CASSANDRA-21366
aweisberg
approved these changes
May 12, 2026
Contributor
aweisberg
left a comment
aweisberg
left a comment
There was a problem hiding this comment.
+1 TY, could really use a test that covers some of the ways this manifested like successfully tracked writes not getting acknowledged or ActiveLogReconciler pushes not resulting in reconciliation. Although ALR is changing so maybe the push is going away?
Member
Author
|
I'll see what the new reconciler shape looks like and if it misses tests for this, will add some. TY |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
patch by Aleksey Yeschenko; reviewed by Ariel Weisberg for CASSANDRA-21366