[CASSANDRA-21399][trunk] Avoid megamorphic call overhead at org.apache.cassandra.io.util.RandomAccessReader#current#4839
Open
netudima wants to merge 1 commit into
Open
Conversation
…mAccessReader#current patch by Dmitry Konstantinov; reviewed by TBD for CASSANDRA-21399
netudima
force-pushed
the
CASSANDRA-21399-trunk
branch
from
e593d57 to
28788cc
Compare
netudima
commented
May 25, 2026
|
|
||
| final Rebufferer rebufferer; | ||
| protected BufferHolder bufferHolder = Rebufferer.EMPTY; | ||
| private BufferHolder bufferHolder = Rebufferer.EMPTY; |
Contributor
Author
There was a problem hiding this comment.
I've made it private to avoid modifying the value in subclasses without updating the paired bufferHolderOffset value
Contributor
There was a problem hiding this comment.
document this in the code explicitly, not just by commenting here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.