-
Notifications
You must be signed in to change notification settings - Fork 3.8k
CASSANDRA-15406 - added progress of streaming in percents in netstats command #558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c1ff627 to
2e88a45
Compare
2e88a45 to
2ba2971
Compare
d297021 to
ab84389
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needed here because without it, the output in netstats look like this, which is wrong:
Repair ec3d7e50-d667-11ea-b3d0-8f5940ba25d7
/127.0.0.1
Receiving 3 files, 1890453 bytes total. Already received 2 files (66.67%), 528363 bytes total (53.09%)
netstats_test/test_table 528363/528363 bytes (100%) received from idx:0/127.0.0.1
New output looks like this:
Repair ec3d7e50-d667-11ea-b3d0-8f5940ba25d7
/127.0.0.1
Receiving 3 files, 1890453 bytes total. Already received 2 files (66.67%), 1003673 bytes total (53.09%)
netstats_test/test_table-1 528363/528363 bytes (100%) received from idx:0/127.0.0.1
netstats_test/test_table-0 221727/221727 bytes (100%) received from idx:0/127.0.0.1
netstats_test/test_table-2 253583/529137 bytes (47%) received from idx:0/127.0.0.1
The problem with the original code is that netstats_test/test_table is periodically put into SessionInfo#updateProgress but since we are putting there same "file name", it is replaced so there is ever just one entry in that map.
"file name" is not completely clear here, it is "logical file name" because it is not fully known yet where that will be be actually saved, the original "file name" does not make sense anyway ... I am appeding the sequence number just for the sake of having it unique.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like this
netstats_test/test_table 528363/528363 bytes (100%) received from idx:0/127.0.0.1
instead of
netstats_test/test_table 528363/528363 bytes(100%) received from idx:0/127.0.0.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
without this method, the progress was not computed correctly.
957d5ff to
bddcfbd
Compare
bddcfbd to
f8686e6
Compare
|
replaced by #711 |
…arn about it (apache#558) Co-authored-by: Matt Fleming <mfleming@users.noreply.github.com>
…arn about it (apache#558) Co-authored-by: Matt Fleming <mfleming@users.noreply.github.com> (cherry picked from commit e20b1de) (cherry picked from commit e383018)
…arn about it (apache#558) Co-authored-by: Matt Fleming <mfleming@users.noreply.github.com> (cherry picked from commit e20b1de) (cherry picked from commit e383018) # Conflicts: # src/java/org/apache/cassandra/config/CassandraRelevantProperties.java # src/java/org/apache/cassandra/streaming/StreamReceiveTask.java
…arn about it (apache#558) Co-authored-by: Matt Fleming <mfleming@users.noreply.github.com> (cherry picked from commit e20b1de) (cherry picked from commit e383018) # Conflicts: # src/java/org/apache/cassandra/config/CassandraRelevantProperties.java # src/java/org/apache/cassandra/streaming/StreamReceiveTask.java
No description provided.