Skip to content

Conversation

@smiklosovic
Copy link
Contributor

No description provided.

@smiklosovic smiklosovic force-pushed the CASSANDRA-15406 branch 3 times, most recently from d297021 to ab84389 Compare August 4, 2020 20:52
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed here because without it, the output in netstats look like this, which is wrong:

Repair ec3d7e50-d667-11ea-b3d0-8f5940ba25d7
    /127.0.0.1
        Receiving 3 files, 1890453 bytes total. Already received 2 files (66.67%), 528363 bytes total (53.09%)
            netstats_test/test_table 528363/528363 bytes (100%) received from idx:0/127.0.0.1

New output looks like this:

Repair ec3d7e50-d667-11ea-b3d0-8f5940ba25d7
    /127.0.0.1
        Receiving 3 files, 1890453 bytes total. Already received 2 files (66.67%), 1003673 bytes total (53.09%)
            netstats_test/test_table-1 528363/528363 bytes (100%) received from idx:0/127.0.0.1
            netstats_test/test_table-0 221727/221727 bytes (100%) received from idx:0/127.0.0.1
            netstats_test/test_table-2 253583/529137 bytes (47%) received from idx:0/127.0.0.1

The problem with the original code is that netstats_test/test_table is periodically put into SessionInfo#updateProgress but since we are putting there same "file name", it is replaced so there is ever just one entry in that map.

"file name" is not completely clear here, it is "logical file name" because it is not fully known yet where that will be be actually saved, the original "file name" does not make sense anyway ... I am appeding the sequence number just for the sake of having it unique.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this

netstats_test/test_table 528363/528363 bytes (100%) received from idx:0/127.0.0.1

instead of

netstats_test/test_table 528363/528363 bytes(100%) received from idx:0/127.0.0.1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without this method, the progress was not computed correctly.

@smiklosovic smiklosovic force-pushed the CASSANDRA-15406 branch 2 times, most recently from 957d5ff to bddcfbd Compare August 5, 2020 09:39
@smiklosovic
Copy link
Contributor Author

replaced by #711

@smiklosovic smiklosovic closed this Aug 6, 2020
@smiklosovic smiklosovic deleted the CASSANDRA-15406 branch August 6, 2020 18:07
blambov pushed a commit to blambov/cassandra that referenced this pull request Nov 24, 2022
…arn about it (apache#558)


Co-authored-by: Matt Fleming <mfleming@users.noreply.github.com>
adelapena pushed a commit to adelapena/cassandra that referenced this pull request Sep 26, 2023
…arn about it (apache#558)

Co-authored-by: Matt Fleming <mfleming@users.noreply.github.com>
(cherry picked from commit e20b1de)
(cherry picked from commit e383018)
ekaterinadimitrova2 pushed a commit to ekaterinadimitrova2/cassandra that referenced this pull request Jun 3, 2024
…arn about it (apache#558)

Co-authored-by: Matt Fleming <mfleming@users.noreply.github.com>
(cherry picked from commit e20b1de)
(cherry picked from commit e383018)

# Conflicts:
#	src/java/org/apache/cassandra/config/CassandraRelevantProperties.java
#	src/java/org/apache/cassandra/streaming/StreamReceiveTask.java
michaelsembwever pushed a commit to thelastpickle/cassandra that referenced this pull request Jan 7, 2026
…arn about it (apache#558)

Co-authored-by: Matt Fleming <mfleming@users.noreply.github.com>
(cherry picked from commit e20b1de)
(cherry picked from commit e383018)

# Conflicts:
#	src/java/org/apache/cassandra/config/CassandraRelevantProperties.java
#	src/java/org/apache/cassandra/streaming/StreamReceiveTask.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant