CASSANDRA-16214 Improve Logging Downstream of DataOutputBuffer Overflows #781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yifan-c
requested changes
Oct 16, 2020
Contributor
yifan-c
left a comment
yifan-c
left a comment
There was a problem hiding this comment.
I think the PR does not cover all callers that can throw BufferOverflowException. Do we only care about the 2 places and convert it to PartitionSerializationException? For the rest, it just throw as BufferOverflowException.
src/java/org/apache/cassandra/db/rows/PartitionSerializationException.java
Outdated
Show resolved
Hide resolved
Contributor
Author
@yifan-c Let me do a quick audit of the other things that might have to catch BOE. |
…t its maximum size, and this allows us to catch it specifically during partition serialization both during compaction and read response creation, where we can throw a more helpful error.
- removed dead checkThrowsRuntimeException() method - switched to getString() - added a couple quick tests around the error message format
maedhroz
force-pushed
the
CASSANDRA-16214
branch
from
3b9dd56 to
4b4f0e4
Compare
Contributor
Author
|
@yifan-c I've addressed your review comments and pushed one more commit. (Tests are in progress...) I didn't expand the use of |
adelapena
pushed a commit
to adelapena/cassandra
that referenced
this pull request
Oct 13, 2023
ekaterinadimitrova2
pushed a commit
to ekaterinadimitrova2/cassandra
that referenced
this pull request
Jun 3, 2024
michaelsembwever
pushed a commit
to thelastpickle/cassandra
that referenced
this pull request
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.