CASSANDRA-16286 Make TokenMetadata's ring version increments atomic #877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blambov
pushed a commit
to blambov/cassandra
that referenced
this pull request
Nov 29, 2023
* Optimize vector searcher limitToTopResults * Only set ceiling objects when the PK is not found * Add test This test fails for the first commit but passes with the fix in the second commit. * Use binary search instead of iterating through PKs * refactor * make callers pass ArrayList to MergePostingList so we can iterate through it more efficiently * r/m expensive assert * don't execute a search for zero candidate keys (nbd for brute force but graph will visit every node) * evaluate maxBruteForceRows after we have an accurate key count * refactor to reduce nesting * fix updateExpectedNodes to use the observed row count instead of segment id (!) * use sublist to represent keys per segment instead of copying them * cleanup * r/m unused TermsIteratorMerger * clarify javadoc * Add exactRowIdOrCeiling method to PKM * switch from bsearch to seq scan when lots of rows match * use sliding window histogram to adapt scan vs bsearch as contents change * cleanup and comment * comment * merge nextAfter into ceiling * Fix logic when clustering columns present; improve method name * Do not share reader for basic ceiling tests * Add warning to javadoc * Update SortedTermsTest to use ceiling at most once --------- Co-authored-by: Jonathan Ellis <jbellis@datastax.com>
ekaterinadimitrova2
pushed a commit
to ekaterinadimitrova2/cassandra
that referenced
this pull request
Jun 3, 2024
* Optimize vector searcher limitToTopResults * Only set ceiling objects when the PK is not found * Add test This test fails for the first commit but passes with the fix in the second commit. * Use binary search instead of iterating through PKs * refactor * make callers pass ArrayList to MergePostingList so we can iterate through it more efficiently * r/m expensive assert * don't execute a search for zero candidate keys (nbd for brute force but graph will visit every node) * evaluate maxBruteForceRows after we have an accurate key count * refactor to reduce nesting * fix updateExpectedNodes to use the observed row count instead of segment id (!) * use sublist to represent keys per segment instead of copying them * cleanup * r/m unused TermsIteratorMerger * clarify javadoc * Add exactRowIdOrCeiling method to PKM * switch from bsearch to seq scan when lots of rows match * use sliding window histogram to adapt scan vs bsearch as contents change * cleanup and comment * comment * merge nextAfter into ceiling * Fix logic when clustering columns present; improve method name * Do not share reader for basic ceiling tests * Add warning to javadoc * Update SortedTermsTest to use ceiling at most once --------- Co-authored-by: Jonathan Ellis <jbellis@datastax.com>
michaelsembwever
pushed a commit
to thelastpickle/cassandra
that referenced
this pull request
Jan 7, 2026
* Optimize vector searcher limitToTopResults * Only set ceiling objects when the PK is not found * Add test This test fails for the first commit but passes with the fix in the second commit. * Use binary search instead of iterating through PKs * refactor * make callers pass ArrayList to MergePostingList so we can iterate through it more efficiently * r/m expensive assert * don't execute a search for zero candidate keys (nbd for brute force but graph will visit every node) * evaluate maxBruteForceRows after we have an accurate key count * refactor to reduce nesting * fix updateExpectedNodes to use the observed row count instead of segment id (!) * use sublist to represent keys per segment instead of copying them * cleanup * r/m unused TermsIteratorMerger * clarify javadoc * Add exactRowIdOrCeiling method to PKM * switch from bsearch to seq scan when lots of rows match * use sliding window histogram to adapt scan vs bsearch as contents change * cleanup and comment * comment * merge nextAfter into ceiling * Fix logic when clustering columns present; improve method name * Do not share reader for basic ceiling tests * Add warning to javadoc * Update SortedTermsTest to use ceiling at most once --------- Co-authored-by: Jonathan Ellis <jbellis@datastax.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.