16453 trunk#904
Closed
ifesdjeen wants to merge 1 commit into
Closed
Conversation
iamaleksey
reviewed
Mar 2, 2021
Member
There was a problem hiding this comment.
Are we sure about the change on this line? I think the condition swap is incorrect, or at the very least the comment above it now is.
…amp tie Patch by Alex Petrov; reviewed by Aleksey Yeschenko and Marcus Eriksson for CASSANDRA-16453.
adelapena
pushed a commit
to adelapena/cassandra
that referenced
this pull request
Jan 2, 2024
…apache#904) Hint version is now optional. If the version is missing, the hint won't be sent. A retry will be attempted later. Messages pre 4.0 use peer address retrieved from the actual connection. Before this patch the messages used the address retrieved from message bytes, which didn't work in MR setups (non public address was used). With the patch, message addressing pre 4.0 is consistent with messages post 4.0.
ekaterinadimitrova2
pushed a commit
to ekaterinadimitrova2/cassandra
that referenced
this pull request
Jun 3, 2024
…apache#904) Hint version is now optional. If the version is missing, the hint won't be sent. A retry will be attempted later. Messages pre 4.0 use peer address retrieved from the actual connection. Before this patch the messages used the address retrieved from message bytes, which didn't work in MR setups (non public address was used). With the patch, message addressing pre 4.0 is consistent with messages post 4.0. (cherry picked from commit 4c7f039)
michaelsembwever
pushed a commit
to thelastpickle/cassandra
that referenced
this pull request
Jan 7, 2026
…apache#904) Hint version is now optional. If the version is missing, the hint won't be sent. A retry will be attempted later. Messages pre 4.0 use peer address retrieved from the actual connection. Before this patch the messages used the address retrieved from message bytes, which didn't work in MR setups (non public address was used). With the patch, message addressing pre 4.0 is consistent with messages post 4.0. (cherry picked from commit 4c7f039)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.