CASSANDRA-16429: Fix incorrect encoding for strings can be UTF8#907
Closed
yifan-c wants to merge 6 commits into
Closed
CASSANDRA-16429: Fix incorrect encoding for strings can be UTF8#907yifan-c wants to merge 6 commits into
yifan-c wants to merge 6 commits into
Conversation
Contributor
ekaterinadimitrova2
left a comment
ekaterinadimitrova2
left a comment
There was a problem hiding this comment.
Looks good to me, as soon as we update also the docs I think it will be good to go.
I had only one small comment on naming conventions
Contributor
There was a problem hiding this comment.
I am fine with changing f1 to fieldname but then shouldn't we do something to f2, f3... to keep the naming consistent?
yifan-c
force-pushed
the
CASSANDRA-16429/trunk
branch
from
5e03b52 to
833b603
Compare
jbellis
pushed a commit
to jbellis/cassandra
that referenced
this pull request
Jan 4, 2024
…patch (apache#907) * In limit to top results, we can skip a call to `primaryKeyMap.exactRowIdOrInvertedCeiling(primaryKey);` when we know the `ceilingPrimaryKey` is equal to a primary key in the `keysInRange` list. * Add a test to verify the fix from apache#902
ekaterinadimitrova2
pushed a commit
to ekaterinadimitrova2/cassandra
that referenced
this pull request
Jun 3, 2024
…patch (apache#907) * In limit to top results, we can skip a call to `primaryKeyMap.exactRowIdOrInvertedCeiling(primaryKey);` when we know the `ceilingPrimaryKey` is equal to a primary key in the `keysInRange` list. * Add a test to verify the fix from apache#902
michaelsembwever
pushed a commit
to thelastpickle/cassandra
that referenced
this pull request
Jan 7, 2026
…patch (apache#907) * In limit to top results, we can skip a call to `primaryKeyMap.exactRowIdOrInvertedCeiling(primaryKey);` when we know the `ceilingPrimaryKey` is equal to a primary key in the `keysInRange` list. * Add a test to verify the fix from apache#902
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.