Fix Streaming Repair metrics #941
Conversation
ekaterinadimitrova2
left a comment
ekaterinadimitrova2
left a comment
There was a problem hiding this comment.
The tests are a bit lengthy to me and I had a few small format suggestions but otherwise it looks ok. Thank you.
Btw if I try to run in Intellij the whole class at once it easily OOMs if I don't raise the memory in advance
There was a problem hiding this comment.
nit: there are 6 occurrences of "]" or ")", can we change it to ']' and ')' respectively
There was a problem hiding this comment.
nit: alignment
There was a problem hiding this comment.
nit: alignment
There was a problem hiding this comment.
nit: alignment
There was a problem hiding this comment.
nit: These are repetitive in both testMetricsWithStreamingToTwoNodes and testMetricsWithStreamingFromTwoNodes; maybe having some additional method and this way also reduce the length of the tests?
There was a problem hiding this comment.
nit: missing spaces between cluster and 2
There was a problem hiding this comment.
nit: missing space between cluster and 1
There was a problem hiding this comment.
nit: space after the first comma
There was a problem hiding this comment.
nit: I would probably comment how we ended up comparing incomingProcessTime.getCount() to files, for clarity
3 participants
No description provided.