Skip to content

Conversation

@azotcsit
Copy link
Contributor

@azotcsit azotcsit commented Apr 4, 2021

References: https://issues.apache.org/jira/browse/CASSANDRA-16645

Context

There is an open discussion in https://issues.apache.org/jira/browse/CASSANDRA-16360 ticket. It looks like such a benchmark would be helpful for further development and changes in checksum calculation logic.

Summary of the changes

  • Added ChecksumBench for benachmarking of checksum calculation
  • Fixed formatting in other benchmarks classes
  • Fixed build-jmh target in build.xml

Open questions

  1. Currently there are two benchmarks commented, but that's done for a purpose with a corresponding comment. I feel it is better to have them commented than every time to recover them. Please, let me know if I need to remove the commented part.

@azotcsit azotcsit changed the title CASSANDRA-16404. Added a benchmark for checksum calculation. CASSANDRA-16360. Added a benchmark for checksum calculation. Apr 4, 2021
@azotcsit azotcsit changed the title CASSANDRA-16360. Added a benchmark for checksum calculation. CASSANDRA-16645. Added a benchmark for checksum calculation. Apr 30, 2021
@azotcsit
Copy link
Contributor Author

Committed as 438a9c8. Closing the PR.

@azotcsit azotcsit closed this Apr 30, 2021
@azotcsit azotcsit deleted the cassandra-16360 branch April 30, 2021 17:07
adelapena pushed a commit to adelapena/cassandra that referenced this pull request Jan 30, 2024
ekaterinadimitrova2 pushed a commit to ekaterinadimitrova2/cassandra that referenced this pull request Jun 3, 2024
michaelsembwever pushed a commit to thelastpickle/cassandra that referenced this pull request Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant