CAY-2748 Mutating the list returned from the local query cache changes the cache#510
Closed
johnthuss wants to merge 1 commit intoapache:masterfrom
Closed
CAY-2748 Mutating the list returned from the local query cache changes the cache#510johnthuss wants to merge 1 commit intoapache:masterfrom
johnthuss wants to merge 1 commit intoapache:masterfrom
Conversation
andrus
reviewed
Jul 9, 2022
| // there was a preexisting cache entry | ||
| if (response == null) { | ||
| response = new ListResponse(cachedResults); | ||
| response = new ListResponse(cachedResults != null ? Collections.unmodifiableList(cachedResults) : null); // make a defensive copy avoid leaking cache internal data |
Contributor
There was a problem hiding this comment.
I think we should store an immutable list in the cache, not wrap it every time we retrieve it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CAY-2748 Mutating the list returned from the local query cache changes the cache
https://issues.apache.org/jira/browse/CAY-2748