[CELEBORN-1405][BUILD] SBT allows using credential without a realm#2484
Closed
pan3793 wants to merge 1 commit intoapache:mainfrom
Closed
[CELEBORN-1405][BUILD] SBT allows using credential without a realm#2484pan3793 wants to merge 1 commit intoapache:mainfrom
pan3793 wants to merge 1 commit intoapache:mainfrom
Conversation
cfmcgrady
approved these changes
May 1, 2024
cxzl25
approved these changes
May 3, 2024
SteNicholas
approved these changes
May 5, 2024
SteNicholas
pushed a commit
that referenced
this pull request
May 5, 2024
### What changes were proposed in this pull request? Change SBT publish credential's realm from hardcoded "Sonatype Nexus Repository Manager" to "". ### Why are the changes needed? According to [SBT docs](https://www.scala-sbt.org/1.x/docs/Publishing.html#Credentials): > Credentials matching is done using both: `realm` and `host` keys. sbt/sbt#2366 allows using credential without a realm by providing an empty string for realm, that's what we wanted exactly. ### Does this PR introduce _any_ user-facing change? Yes, before this change, when I tried to publish the artifacts to a private corp nexus, it failed with 401 even with corrected `ASF_USERNAME` and `ASF_PASSWORD`. The publication works well after this change. ### How was this patch tested? Manually tests. Closes #2484 from pan3793/CELEBORN-1405. Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: SteNicholas <programgeek@163.com> (cherry picked from commit 8548e50) Signed-off-by: SteNicholas <programgeek@163.com>
cfmcgrady
pushed a commit
to cfmcgrady/incubator-celeborn
that referenced
this pull request
Aug 21, 2025
### What changes were proposed in this pull request? Change SBT publish credential's realm from hardcoded "Sonatype Nexus Repository Manager" to "". ### Why are the changes needed? According to [SBT docs](https://www.scala-sbt.org/1.x/docs/Publishing.html#Credentials): > Credentials matching is done using both: `realm` and `host` keys. sbt/sbt#2366 allows using credential without a realm by providing an empty string for realm, that's what we wanted exactly. ### Does this PR introduce _any_ user-facing change? Yes, before this change, when I tried to publish the artifacts to a private corp nexus, it failed with 401 even with corrected `ASF_USERNAME` and `ASF_PASSWORD`. The publication works well after this change. ### How was this patch tested? Manually tests. Closes apache#2484 from pan3793/CELEBORN-1405. Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: SteNicholas <programgeek@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Change SBT publish credential's realm from hardcoded "Sonatype Nexus Repository Manager" to "".
Why are the changes needed?
According to SBT docs:
sbt/sbt#2366 allows using credential without a realm by providing an empty string for realm, that's what we wanted exactly.
Does this PR introduce any user-facing change?
Yes, before this change, when I tried to publish the artifacts to a private corp nexus, it failed with 401 even with corrected
ASF_USERNAMEandASF_PASSWORD. The publication works well after this change.How was this patch tested?
Manually tests.