[CELEBORN-1414] PartitionFilesSorter resolve DiskFileInfo without sorting lock#2498
Closed
SteNicholas wants to merge 1 commit intoapache:mainfrom
Closed
[CELEBORN-1414] PartitionFilesSorter resolve DiskFileInfo without sorting lock#2498SteNicholas wants to merge 1 commit intoapache:mainfrom
SteNicholas wants to merge 1 commit intoapache:mainfrom
Conversation
SteNicholas
force-pushed
the
CELEBORN-1414
branch
2 times, most recently
from
83ab37e to
e4566d1
Compare
Member
Author
|
Ping @RexXiong, @FMX, @cfmcgrady. |
Member
Author
|
@FMX, @cfmcgrady, PTAL. |
Member
Author
|
Merging to main(v0.5.0). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
PartitionFilesSortercallsresolveofDiskFileInfowithoutsortinglock to reduce the lock scope for performance improvement ofgetSortedFileInfo.Why are the changes needed?
PartitionFilesSorter#resolveis thread safe. Therefore,PartitionFilesSorterinvokesresolvewithsortinglock at present, which does not need to lock the resolving ofDiskFileInfo.PartitionFilesSortercould resolveDiskFileInfowithoutsortinglock to improve performance ofgetSortedFileInfo.Does this PR introduce any user-facing change?
No.
How was this patch tested?
GA.