[CELEBORN-1416] Add CI for helm charts lint and test#2513
Closed
ChenYi015 wants to merge 6 commits intoapache:mainfrom
Closed
[CELEBORN-1416] Add CI for helm charts lint and test#2513ChenYi015 wants to merge 6 commits intoapache:mainfrom
ChenYi015 wants to merge 6 commits intoapache:mainfrom
Conversation
ChenYi015
force-pushed
the
workflow/helm-charts
branch
3 times, most recently
from
121cee2 to
bdbea42
Compare
Contributor
Author
|
@pan3793 Can we allow to run actions/helm-chart-testing in CI. |
Member
|
@ChenYi015 please follow ASF GHA policy https://infra.apache.org/github-actions-policy.html |
ChenYi015
force-pushed
the
workflow/helm-charts
branch
2 times, most recently
from
db794d2 to
1d15f5b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2513 +/- ##
==========================================
+ Coverage 40.17% 40.80% +0.63%
==========================================
Files 218 220 +2
Lines 13742 14096 +354
Branches 1214 1258 +44
==========================================
+ Hits 5520 5751 +231
- Misses 7905 8017 +112
- Partials 317 328 +11 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
@pan3793 PTAL, thanks! |
pan3793
reviewed
May 16, 2024
pan3793
reviewed
May 16, 2024
pan3793
reviewed
May 16, 2024
ChenYi015
force-pushed
the
workflow/helm-charts
branch
from
9fa2943 to
6bd439a
Compare
Signed-off-by: Yi Chen <github@chenyicn.net>
Signed-off-by: Yi Chen <github@chenyicn.net>
ChenYi015
force-pushed
the
workflow/helm-charts
branch
from
6bd439a to
39065ef
Compare
Signed-off-by: Yi Chen <github@chenyicn.net>
Signed-off-by: Yi Chen <github@chenyicn.net>
Signed-off-by: Yi Chen <github@chenyicn.net>
Signed-off-by: Yi Chen <github@chenyicn.net>
pan3793
approved these changes
May 16, 2024
Member
|
Thanks, merged to main for 0.5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
tests/kubernetes-it/docker/helm/values.yamltocharts/celeborn/ci/values.yaml, as this is a common convention, for example prometheus-community/helm-charts..helmignorefile to specify patterns for files and directories that should be ignored when packaging the chart.actions/setup-helmtov4.2.0actions/setup-pythontov5actions/setup-javatov4actions/checkouttov4Why are the changes needed?
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Local test.