[CELEBORN-1447] Support configuring thread number of worker to wait for commit shuffle data files to finish#2539
Closed
SteNicholas wants to merge 1 commit intoapache:mainfrom
Closed
[CELEBORN-1447] Support configuring thread number of worker to wait for commit shuffle data files to finish#2539SteNicholas wants to merge 1 commit intoapache:mainfrom
SteNicholas wants to merge 1 commit intoapache:mainfrom
Conversation
…or commit shuffle data files to finish
Member
Author
|
Ping @FMX, @waitinfuture, @RexXiong. |
FMX
approved these changes
Jun 3, 2024
Contributor
FMX
left a comment
FMX
left a comment
There was a problem hiding this comment.
LGTM. Thanks. Merged into main(v0.6.0) and branch-0.5(v0.5.0).
cfmcgrady
pushed a commit
to cfmcgrady/incubator-celeborn
that referenced
this pull request
Aug 21, 2025
…or commit shuffle data files to finish Introduce `celeborn.worker.commitFiles.wait.threads` to support configuring thread number of worker to wait for commit shuffle data files to finish. `celeborn.worker.commitFiles.threads` supports the configuration that is the thread number of worker to commit shuffle data files asynchronously including waiting for commit files to finish at present. It should support to configure thread number of waiting for commit shuffle data files to finish which avoids the situation where the commit thread pool is waiting for commit files and no thread could commit shuffle data files. No. GA. Closes apache#2539 from SteNicholas/CELEBORN-1447. Authored-by: SteNicholas <programgeek@163.com> Signed-off-by: mingji <fengmingxiao.fmx@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Introduce
celeborn.worker.commitFiles.wait.threadsto support configuring thread number of worker to wait for commit shuffle data files to finish.Why are the changes needed?
celeborn.worker.commitFiles.threadssupports the configuration that is the thread number of worker to commit shuffle data files asynchronously including waiting for commit files to finish at present. It should support to configure thread number of waiting for commit shuffle data files to finish which avoids the situation where the commit thread pool is waiting for commit files and no thread could commit shuffle data files.Does this PR introduce any user-facing change?
No.
How was this patch tested?
GA.