Skip to content

[CELEBORN-1458][DOC] Introduce decommissioning document#2554

Closed
AngersZhuuuu wants to merge 19 commits intoapache:mainfrom
AngersZhuuuu:CELEBORN-1458
Closed

[CELEBORN-1458][DOC] Introduce decommissioning document#2554
AngersZhuuuu wants to merge 19 commits intoapache:mainfrom
AngersZhuuuu:CELEBORN-1458

Conversation

@AngersZhuuuu
Copy link
Contributor

@AngersZhuuuu AngersZhuuuu commented Jun 11, 2024

What changes were proposed in this pull request?

Introduce decommissioning document to provide users with introduction of worker decommissioning.

Why are the changes needed?

Users should know operation of worker decommissioning maintenance.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

No.

@AngersZhuuuu
Copy link
Contributor Author

ping @SteNicholas @RexXiong @waitinfuture

@apache apache deleted a comment from AngersZhuuuu Jun 11, 2024
@SteNicholas SteNicholas changed the title [CELEBORN-1458][DOC] Add doc for decommission [CELEBORN-1458][DOC] Introduce worker decommission document Jun 12, 2024
AngersZhuuuu and others added 4 commits June 12, 2024 16:08
Co-authored-by: Nicholas Jiang <programgeek@163.com>
Co-authored-by: Nicholas Jiang <programgeek@163.com>
Co-authored-by: Nicholas Jiang <programgeek@163.com>
@SteNicholas SteNicholas changed the title [CELEBORN-1458][DOC] Introduce worker decommission document [CELEBORN-1458][DOC] Introduce decommissioning document Jun 12, 2024
@SteNicholas
Copy link
Member

@AngersZhuuuu, thanks for udpates. I left the minor comments for the changes. You could rename decommission.md to decommissioning.md which follows the pattern of upgrading.md. PTAL.

@AngersZhuuuu
Copy link
Contributor Author

@AngersZhuuuu, thanks for udpates. I left the minor comments for the changes. You could rename decommission.md to decommissioning.md which follows the pattern of upgrading.md. PTAL.

Done

@codecov
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.49%. Comparing base (50eaaf7) to head (a5ff5de).
Report is 15 commits behind head on main.

Current head a5ff5de differs from pull request most recent head dc04a48

Please upload reports for the commit dc04a48 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2554      +/-   ##
==========================================
- Coverage   40.58%   40.49%   -0.08%     
==========================================
  Files         222      222              
  Lines       14261    14289      +28     
  Branches     1284     1291       +7     
==========================================
- Hits         5786     5785       -1     
- Misses       8145     8173      +28     
- Partials      330      331       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

limitations under the License.
---

Decommissioning
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfer change Decommissioning to scaling include scale up/scale down. For scaling up, Celeborn only needs additional workers to be added. For scaling down, decommissioning is required first.

@RexXiong RexXiong closed this in d7e1510 Jun 14, 2024
@RexXiong
Copy link
Contributor

merge to main(v0.6.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants