[CELEBORN-1459] Introduce CleanTaskQueueSize and CleanExpiredShuffleKeysTime to record situation of cleaning up expired shuffle keys#2557
Closed
SteNicholas wants to merge 1 commit intoapache:mainfrom
Closed
Conversation
SteNicholas
force-pushed
the
CELEBORN-1459
branch
from
30d134e to
8a554eb
Compare
FMX
reviewed
Jun 14, 2024
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/Worker.scala
Outdated
Show resolved
Hide resolved
FMX
reviewed
Jun 14, 2024
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/Worker.scala
Outdated
Show resolved
Hide resolved
FMX
reviewed
Jun 18, 2024
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/Worker.scala
Outdated
Show resolved
Hide resolved
SteNicholas
force-pushed
the
CELEBORN-1459
branch
from
9f178f1 to
e778b7e
Compare
SteNicholas
force-pushed
the
CELEBORN-1459
branch
from
e778b7e to
4726cd5
Compare
…eysTime to record situation of cleaning up expired shuffle keys
SteNicholas
force-pushed
the
CELEBORN-1459
branch
from
4726cd5 to
e80604a
Compare
FMX
approved these changes
Jun 18, 2024
Contributor
FMX
left a comment
FMX
left a comment
There was a problem hiding this comment.
LGTM. Thanks. Merged into main(v0.6.0) and branch-0.5(v0.5.0).
FMX
pushed a commit
that referenced
this pull request
Jun 18, 2024
…eysTime to record situation of cleaning up expired shuffle keys Introduce `CleanTaskQueueSize` and `CleanExpiredShuffleKeysTime` to record situation of cleaning up expired shuffle keys. There is a backlog of task queue for cleaning up shuffle data of expired shuffle keys in the production environment. It's recommended to introduce `CleanTaskQueueSize` and `CleanExpiredShuffleKeysTime` to record the progress of cleaning up expired shuffle keys. No. [Celeborn Grafana Dashboard](https://stenicholas.grafana.net/public-dashboards/4b5a0b79a35e4ddbb18ddccfe2ec06d7) Closes #2557 from SteNicholas/CELEBORN-1459. Authored-by: SteNicholas <programgeek@163.com> Signed-off-by: mingji <fengmingxiao.fmx@alibaba-inc.com> (cherry picked from commit c7b1b8d) Signed-off-by: mingji <fengmingxiao.fmx@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Introduce
CleanTaskQueueSizeandCleanExpiredShuffleKeysTimeto record situation of cleaning up expired shuffle keys.Why are the changes needed?
There is a backlog of task queue for cleaning up shuffle data of expired shuffle keys in the production environment. It's recommended to introduce
CleanTaskQueueSizeandCleanExpiredShuffleKeysTimeto record the progress of cleaning up expired shuffle keys.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Celeborn Grafana Dashboard