[CELEBORN-1457][0.4] Avoid NPE during shuffle data cleanup#2565
Closed
cfmcgrady wants to merge 1 commit intoapache:branch-0.4from
Closed
[CELEBORN-1457][0.4] Avoid NPE during shuffle data cleanup#2565cfmcgrady wants to merge 1 commit intoapache:branch-0.4from
cfmcgrady wants to merge 1 commit intoapache:branch-0.4from
Conversation
### What changes were proposed in this pull request? Avoid NPE during shuffle data cleanup by checking for null LevelDB. ### Why are the changes needed? If the LevelDB in StorageManager fails to initialize, the db will be null. This will cause a java.lang.NullPointerException when storageManager.cleanupExpiredShuffleKey(expiredShuffleKeys) is called, and the shuffle data in expiredShuffleKeys will not be cleaned up. The worker's disk may be filled up as a result. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Manual Testing Closes apache#2553 from jiang13021/celeborn-1457. Authored-by: jiang13021 <jiangyanze.jyz@antgroup.com> Signed-off-by: SteNicholas <programgeek@163.com>
cfmcgrady
force-pushed
the
CELEBORN-1457-branch-0.4
branch
from
54b7de2 to
d9478e5
Compare
pan3793
approved these changes
Jun 14, 2024
Contributor
Author
|
thanks, merging to branch-0.4(v0.4.2). |
cfmcgrady
pushed a commit
that referenced
this pull request
Jun 14, 2024
### What changes were proposed in this pull request? backport #2553 to `branch-0.4` Avoid NPE during shuffle data cleanup by checking for null LevelDB. ### Why are the changes needed? If the LevelDB in StorageManager fails to initialize, the db will be null. This will cause a java.lang.NullPointerException when storageManager.cleanupExpiredShuffleKey(expiredShuffleKeys) is called, and the shuffle data in expiredShuffleKeys will not be cleaned up. The worker's disk may be filled up as a result. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Manual Testing Closes #2565 from cfmcgrady/CELEBORN-1457-branch-0.4. Authored-by: jiang13021 <jiangyanze.jyz@antgroup.com> Signed-off-by: Fu Chen <cfmcgrady@gmail.com>
cfmcgrady
pushed a commit
to cfmcgrady/incubator-celeborn
that referenced
this pull request
Aug 21, 2025
### What changes were proposed in this pull request? backport apache#2553 to `branch-0.4` Avoid NPE during shuffle data cleanup by checking for null LevelDB. ### Why are the changes needed? If the LevelDB in StorageManager fails to initialize, the db will be null. This will cause a java.lang.NullPointerException when storageManager.cleanupExpiredShuffleKey(expiredShuffleKeys) is called, and the shuffle data in expiredShuffleKeys will not be cleaned up. The worker's disk may be filled up as a result. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Manual Testing Closes apache#2565 from cfmcgrady/CELEBORN-1457-branch-0.4. Authored-by: jiang13021 <jiangyanze.jyz@antgroup.com> Signed-off-by: Fu Chen <cfmcgrady@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
backport #2553 to
branch-0.4Avoid NPE during shuffle data cleanup by checking for null LevelDB.
Why are the changes needed?
If the LevelDB in StorageManager fails to initialize, the db will be null. This will cause a java.lang.NullPointerException when storageManager.cleanupExpiredShuffleKey(expiredShuffleKeys) is called, and the shuffle data in expiredShuffleKeys will not be cleaned up. The worker's disk may be filled up as a result.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Manual Testing