[CELEBORN-1463][FOLLOWUP] Respeact client/server threads num to avoid competitiveness#2571
Closed
zwangsheng wants to merge 1 commit intomainfrom
Closed
[CELEBORN-1463][FOLLOWUP] Respeact client/server threads num to avoid competitiveness#2571zwangsheng wants to merge 1 commit intomainfrom
zwangsheng wants to merge 1 commit intomainfrom
Conversation
SteNicholas
reviewed
Jun 17, 2024
| if (coreNum != 0) { | ||
| arenas = coreNum; | ||
| } else { | ||
| arenas = conf.getCelebornConf().networkAllocatorArenas(); |
Member
There was a problem hiding this comment.
Could this limit the arena with netty max thread num to avoid the config value is too large?
Contributor
Author
There was a problem hiding this comment.
Should we limit this max value in conf.getCelebornConf().networkAllocatorArenas() or just in this un-shared pool memory allocator case?
Contributor
There was a problem hiding this comment.
User environments are various, there won't be a proper limit for all environments. I think this should have no limit.
Contributor
|
Merged into main(v0.6.0), branch-0.5(v0.5.0), branch-0.4(v0.4.2). |
FMX
pushed a commit
that referenced
this pull request
Jun 18, 2024
… competitiveness ### What changes were proposed in this pull request? #2570 Respect client/server threads num when create transport client/server memory allocator. ### Why are the changes needed? Follow up, as title. Respeact client/server threads num to avoid competitiveness ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? No Closes #2571 from zwangsheng/CELEBORN-1463-follow-up. Authored-by: binjie yang <yangbinjie@shizhuang-inc.com> Signed-off-by: mingji <fengmingxiao.fmx@alibaba-inc.com> (cherry picked from commit 565e39a) Signed-off-by: mingji <fengmingxiao.fmx@alibaba-inc.com>
FMX
pushed a commit
that referenced
this pull request
Jun 18, 2024
… competitiveness ### What changes were proposed in this pull request? #2570 Respect client/server threads num when create transport client/server memory allocator. ### Why are the changes needed? Follow up, as title. Respeact client/server threads num to avoid competitiveness ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? No Closes #2571 from zwangsheng/CELEBORN-1463-follow-up. Authored-by: binjie yang <yangbinjie@shizhuang-inc.com> Signed-off-by: mingji <fengmingxiao.fmx@alibaba-inc.com> (cherry picked from commit 565e39a) Signed-off-by: mingji <fengmingxiao.fmx@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
#2570
Respect client/server threads num when create transport client/server memory allocator.
Why are the changes needed?
Follow up, as title.
Respeact client/server threads num to avoid competitiveness
Does this PR introduce any user-facing change?
No
How was this patch tested?
No