Skip to content

Comments

[CELEBORN-1534] Order the API v1 response sequences filed#2656

Closed
turboFei wants to merge 1 commit intoapache:mainfrom
turboFei:sort_response
Closed

[CELEBORN-1534] Order the API v1 response sequences filed#2656
turboFei wants to merge 1 commit intoapache:mainfrom
turboFei:sort_response

Conversation

@turboFei
Copy link
Member

@turboFei turboFei commented Jul 31, 2024 •
edited
Loading

What changes were proposed in this pull request?

Make the results returned by the API v1 in order.

Why are the changes needed?

For customer interface friendly.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Not needed.

@turboFei turboFei changed the title Sort the api v1 response sequence Make the results returned by the API v1 in order Jul 31, 2024
@turboFei turboFei changed the title Make the results returned by the API v1 in order [CELEBORN-1534] Make the results returned by the API v1 in order Jul 31, 2024
@turboFei turboFei changed the title [CELEBORN-1534] Make the results returned by the API v1 in order [CELEBORN-1534] Order the API v1 response sequences filed Aug 1, 2024
@turboFei turboFei requested a review from pan3793 August 1, 2024 22:57
RexXiong
RexXiong approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@RexXiong RexXiong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pan3793
Copy link
Member

pan3793 commented Aug 6, 2024

it might be costly for sorting shuffle_id and application_id listing API, cc @AngersZhuuuu

@turboFei
Copy link
Member Author

turboFei commented Aug 6, 2024

it might be costly for sorting shuffle_id and application_id listing API
If that, I can remove the order for them

@turboFei
Copy link
Member Author

turboFei commented Aug 6, 2024

maybe we can sort the response in client side.

Waiting for the celeborn-CLI.

@RexXiong
Copy link
Contributor

RexXiong commented Aug 8, 2024

it might be costly for sorting shuffle_id and application_id listing API, cc @AngersZhuuuu

Perhaps we could add an option to choose between sorted and unsorted results?

@github-actions
Copy link

github-actions bot commented Aug 29, 2024

This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale label Aug 29, 2024
@RexXiong RexXiong removed the stale label Aug 29, 2024
@github-actions
Copy link

github-actions bot commented Sep 19, 2024

This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale label Sep 19, 2024
@github-actions
Copy link

github-actions bot commented Sep 30, 2024

This issue was closed because it has been staled for 10 days with no activity.

@github-actions github-actions bot closed this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RexXiong RexXiong RexXiong approved these changes

@pan3793 pan3793 Awaiting requested review from pan3793

Assignees

No one assigned

Labels

stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@turboFei @pan3793 @RexXiong