[CELEBORN-1521][FOLLOWUP] Move BasicPrincipal to spi module#2665
Closed
turboFei wants to merge 2 commits intoapache:mainfrom
Closed
[CELEBORN-1521][FOLLOWUP] Move BasicPrincipal to spi module#2665turboFei wants to merge 2 commits intoapache:mainfrom
turboFei wants to merge 2 commits intoapache:mainfrom
Conversation
turboFei
changed the title
turboFei
changed the title
Member
Author
|
cc @pan3793 |
Member
I'm not against this, but does it have benefits?
I would keep this, the developer still has the option to write custom plugins in their forked celeborn repo |
Member
Author
The only benefit is that, customer do not need to implement java.security.Principal by them, that is all |
Member
sounds reasonable |
turboFei
changed the title
pan3793
approved these changes
Aug 6, 2024
Member
|
Merged to main |
wankunde
pushed a commit
to wankunde/celeborn
that referenced
this pull request
Oct 11, 2024
### What changes were proposed in this pull request? This PS is a followup of CELEBORN-1521, move the BasicPrincipal in to celeborn-spi module. so that customer do not need to implement it by themselves. ### Why are the changes needed? For authentication extension. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing GA. Closes apache#2665 from turboFei/spi_follow. Authored-by: Wang, Fei <fwang12@ebay.com> Signed-off-by: Cheng Pan <chengpan@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PS is a followup of CELEBORN-1521, move the BasicPrincipal in to celeborn-spi module. so that customer do not need to implement it by themselves.
Why are the changes needed?
For authentication extension.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing GA.