[CELEBORN-1553] Using the request base url as swagger server#2674
Closed
turboFei wants to merge 3 commits intoapache:mainfrom
Closed
[CELEBORN-1553] Using the request base url as swagger server#2674turboFei wants to merge 3 commits intoapache:mainfrom
turboFei wants to merge 3 commits intoapache:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2674 +/- ##
==========================================
- Coverage 39.83% 33.35% -6.47%
==========================================
Files 239 310 +71
Lines 15026 18193 +3167
Branches 1362 1672 +310
==========================================
+ Hits 5984 6067 +83
- Misses 8711 11786 +3075
- Partials 331 340 +9 ☔ View full report in Codecov by Sentry. |
169407a to
6c885a9
Compare
Member
Author
|
cc @pan3793 |
6c885a9 to
1fcbfa0
Compare
1fcbfa0 to
2bf08bb
Compare
Member
Author
|
also cc @cfmcgrady @SteNicholas |
Member
Author
|
Hi @RexXiong If no more comments, can we merge it? thanks |
Contributor
Thanks for the reminder. Merge to main(v0.6.0) |
s0nskar
pushed a commit
to s0nskar/celeborn
that referenced
this pull request
Sep 16, 2024
### What changes were proposed in this pull request? Using the request base url as swagger server, to prevent the swagger server not reachable and `CORS` error if the swagger server urls do not match. Currently, if the http host is bound to local, the swagger server is not reachable. For example: ``` celeborn.master.http.host=0.0.0.0 celeborn.worker.http.host=0.0.0.0 ``` ### Why are the changes needed?  ### Does this PR introduce _any_ user-facing change? No, just use the request base url as swagger server. ### How was this patch tested? Integration testing: <img width="1483" alt="image" src="https://github.com/user-attachments/assets/f8465bcb-a266-4532-9f11-52e9374c56a5"> <img width="1423" alt="image" src="https://github.com/user-attachments/assets/84eacd86-7ba3-4f14-907b-6d529c6e0e28"> Closes apache#2674 from turboFei/swagger_server. Authored-by: Wang, Fei <fwang12@ebay.com> Signed-off-by: Shuang <lvshuang.xjs@alibaba-inc.com>
wankunde
pushed a commit
to wankunde/celeborn
that referenced
this pull request
Oct 11, 2024
### What changes were proposed in this pull request? Using the request base url as swagger server, to prevent the swagger server not reachable and `CORS` error if the swagger server urls do not match. Currently, if the http host is bound to local, the swagger server is not reachable. For example: ``` celeborn.master.http.host=0.0.0.0 celeborn.worker.http.host=0.0.0.0 ``` ### Why are the changes needed?  ### Does this PR introduce _any_ user-facing change? No, just use the request base url as swagger server. ### How was this patch tested? Integration testing: <img width="1483" alt="image" src="https://github.com/user-attachments/assets/f8465bcb-a266-4532-9f11-52e9374c56a5"> <img width="1423" alt="image" src="https://github.com/user-attachments/assets/84eacd86-7ba3-4f14-907b-6d529c6e0e28"> Closes apache#2674 from turboFei/swagger_server. Authored-by: Wang, Fei <fwang12@ebay.com> Signed-off-by: Shuang <lvshuang.xjs@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Using the request base url as swagger server, to prevent the swagger server not reachable and
CORSerror if the swagger server urls do not match.Currently, if the http host is bound to local, the swagger server is not reachable.
For example:
Why are the changes needed?
Does this PR introduce any user-facing change?
No, just use the request base url as swagger server.
How was this patch tested?
Integration testing:
