[CELEBORN-1559]Fix make distribution script failed to recognize specific profile#2682
Closed
zhaohehuhu wants to merge 2 commits intoapache:mainfrom
Closed
[CELEBORN-1559]Fix make distribution script failed to recognize specific profile#2682zhaohehuhu wants to merge 2 commits intoapache:mainfrom
zhaohehuhu wants to merge 2 commits intoapache:mainfrom
Conversation
zhaohehuhu
changed the title
Contributor
Author
|
plz review this PR. Thanks @FMX |
Member
|
@zhaohehuhu, please update the title of this pull request to link with ticket. |
Contributor
Author
Got it. Thanks. |
zhaohehuhu
changed the title
FMX
reviewed
Aug 15, 2024
build/make-distribution.sh
Outdated
| if [[ "$HADOOP_AWS_ENABLED" == "true" ]]; then | ||
|
|
||
| if [[ $@ == *"hadoop-aws"* ]]; then | ||
| export SBT_MAVEN_PROFILES="hadoop-aws" |
Contributor
There was a problem hiding this comment.
There is no need to export this variable. Just setting this variable should be enough.
FMX
approved these changes
Aug 15, 2024
Contributor
FMX
left a comment
FMX
left a comment
There was a problem hiding this comment.
LGTM. Thanks. Merged into main(v0.6.0).
zaynt4606
pushed a commit
to zaynt4606/celeborn
that referenced
this pull request
Aug 16, 2024
…ific profile <!-- Thanks for sending a pull request! Here are some tips for you: - Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'. - Be sure to keep the PR description updated to reflect all changes. - Please write your PR title to summarize what this PR proposes. - If possible, provide a concise example to reproduce the issue for a faster review. --> ### What changes were proposed in this pull request? as title ### Why are the changes needed? When I run the command(./build/make-distribution.sh -Pflink-1.16), the profiles can be resolved and built. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Yes Closes apache#2682 from zhaohehuhu/dev-0814. Authored-by: zhaohehuhu <luoyedeyi@163.com> Signed-off-by: mingji <fengmingxiao.fmx@alibaba-inc.com>
wankunde
pushed a commit
to wankunde/celeborn
that referenced
this pull request
Oct 11, 2024
…ific profile <!-- Thanks for sending a pull request! Here are some tips for you: - Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'. - Be sure to keep the PR description updated to reflect all changes. - Please write your PR title to summarize what this PR proposes. - If possible, provide a concise example to reproduce the issue for a faster review. --> ### What changes were proposed in this pull request? as title ### Why are the changes needed? When I run the command(./build/make-distribution.sh -Pflink-1.16), the profiles can be resolved and built. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Yes Closes apache#2682 from zhaohehuhu/dev-0814. Authored-by: zhaohehuhu <luoyedeyi@163.com> Signed-off-by: mingji <fengmingxiao.fmx@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
as title
Why are the changes needed?
When I run the command(./build/make-distribution.sh -Pflink-1.16), the profiles can be resolved and built.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Yes