[CELEBORN-1557] Fix totalSpace of DiskInfo for Master in HA mode#2690
Closed
SteNicholas wants to merge 2 commits intoapache:mainfrom
Closed
[CELEBORN-1557] Fix totalSpace of DiskInfo for Master in HA mode#2690SteNicholas wants to merge 2 commits intoapache:mainfrom
SteNicholas wants to merge 2 commits intoapache:mainfrom
Conversation
SteNicholas
force-pushed
the
CELEBORN-1557
branch
from
8e13bcb to
546671c
Compare
FMX
reviewed
Aug 16, 2024
SteNicholas
force-pushed
the
CELEBORN-1557
branch
from
32fc5a9 to
83fc7ef
Compare
FMX
approved these changes
Aug 19, 2024
Contributor
FMX
left a comment
FMX
left a comment
There was a problem hiding this comment.
LGTM. Merged into main(v0.6.0) , branch-0.5(v0.5.2).
FMX
pushed a commit
that referenced
this pull request
Aug 19, 2024
### What changes were proposed in this pull request? Fix `totalSpace` of `DiskInfo` for Master in HA mode. ### Why are the changes needed? The `totalSpace` of `DiskInfo` does not sync for Master in HA mode, which causes that the `totalSpace` is incorrect. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? `RatisMasterStatusSystemSuiteJ#testHandleRegisterWorker` Closes #2690 from SteNicholas/CELEBORN-1557. Authored-by: SteNicholas <programgeek@163.com> Signed-off-by: mingji <fengmingxiao.fmx@alibaba-inc.com> (cherry picked from commit b330b55) Signed-off-by: mingji <fengmingxiao.fmx@alibaba-inc.com>
wankunde
pushed a commit
to wankunde/celeborn
that referenced
this pull request
Oct 11, 2024
### What changes were proposed in this pull request? Fix `totalSpace` of `DiskInfo` for Master in HA mode. ### Why are the changes needed? The `totalSpace` of `DiskInfo` does not sync for Master in HA mode, which causes that the `totalSpace` is incorrect. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? `RatisMasterStatusSystemSuiteJ#testHandleRegisterWorker` Closes apache#2690 from SteNicholas/CELEBORN-1557. Authored-by: SteNicholas <programgeek@163.com> Signed-off-by: mingji <fengmingxiao.fmx@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix
totalSpaceofDiskInfofor Master in HA mode.Why are the changes needed?
The
totalSpaceofDiskInfodoes not sync for Master in HA mode, which causes that thetotalSpaceis incorrect.Does this PR introduce any user-facing change?
No.
How was this patch tested?
RatisMasterStatusSystemSuiteJ#testHandleRegisterWorker