[CELEBORN-1580] ReadBufferDispacther should notify exception to listener#2707
Closed
codenohup wants to merge 3 commits intoapache:mainfrom
Closed
[CELEBORN-1580] ReadBufferDispacther should notify exception to listener#2707codenohup wants to merge 3 commits intoapache:mainfrom
codenohup wants to merge 3 commits intoapache:mainfrom
Conversation
Contributor
|
The ReadBufferDispatcher may encounter an exception when a Netty OutOfDirectMemoryError occurs. In this case, we should allow the map partition reader to retry; otherwise, the Flink Task Manager could hang. cc @SteNicholas @mridulm |
RexXiong
approved these changes
Aug 28, 2024
SteNicholas
pushed a commit
that referenced
this pull request
Aug 28, 2024
### What changes were proposed in this pull request? When the ReadBufferDispatcher encounters an exception, it should notify an exception to listener. The listener is responsible for informing the Celeborn client of the error and initiating some fault tolerance strategies. ### Why are the changes needed? If the ReadBufferDispatcher don't notify the listener of an exception message, it may result in the listener (MapPartitionDataReader) being stuck in a prolonged wait state, ultimately leading to the job hanging. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Add an unit test case. Closes #2707 from codenohup/fix-oom. Authored-by: codenohup <huangxu.walker@gmail.com> Signed-off-by: SteNicholas <programgeek@163.com> (cherry picked from commit c233929) Signed-off-by: SteNicholas <programgeek@163.com>
Member
|
@codenohup, thanks for contribution. Merged to main(v0.6.0) and branch-0.5(v0.5.2). |
zaynt4606
pushed a commit
to zaynt4606/celeborn
that referenced
this pull request
Aug 29, 2024
### What changes were proposed in this pull request? When the ReadBufferDispatcher encounters an exception, it should notify an exception to listener. The listener is responsible for informing the Celeborn client of the error and initiating some fault tolerance strategies. ### Why are the changes needed? If the ReadBufferDispatcher don't notify the listener of an exception message, it may result in the listener (MapPartitionDataReader) being stuck in a prolonged wait state, ultimately leading to the job hanging. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Add an unit test case. Closes apache#2707 from codenohup/fix-oom. Authored-by: codenohup <huangxu.walker@gmail.com> Signed-off-by: SteNicholas <programgeek@163.com>
s0nskar
pushed a commit
to s0nskar/celeborn
that referenced
this pull request
Sep 16, 2024
### What changes were proposed in this pull request? When the ReadBufferDispatcher encounters an exception, it should notify an exception to listener. The listener is responsible for informing the Celeborn client of the error and initiating some fault tolerance strategies. ### Why are the changes needed? If the ReadBufferDispatcher don't notify the listener of an exception message, it may result in the listener (MapPartitionDataReader) being stuck in a prolonged wait state, ultimately leading to the job hanging. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Add an unit test case. Closes apache#2707 from codenohup/fix-oom. Authored-by: codenohup <huangxu.walker@gmail.com> Signed-off-by: SteNicholas <programgeek@163.com>
wankunde
pushed a commit
to wankunde/celeborn
that referenced
this pull request
Oct 11, 2024
### What changes were proposed in this pull request? When the ReadBufferDispatcher encounters an exception, it should notify an exception to listener. The listener is responsible for informing the Celeborn client of the error and initiating some fault tolerance strategies. ### Why are the changes needed? If the ReadBufferDispatcher don't notify the listener of an exception message, it may result in the listener (MapPartitionDataReader) being stuck in a prolonged wait state, ultimately leading to the job hanging. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Add an unit test case. Closes apache#2707 from codenohup/fix-oom. Authored-by: codenohup <huangxu.walker@gmail.com> Signed-off-by: SteNicholas <programgeek@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When the ReadBufferDispatcher encounters an exception, it should notify an exception to listener. The listener is responsible for informing the Celeborn client of the error and initiating some fault tolerance strategies.
Why are the changes needed?
If the ReadBufferDispatcher don't notify the listener of an exception message, it may result in the listener (MapPartitionDataReader) being stuck in a prolonged wait state, ultimately leading to the job hanging.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Add an unit test case.