-
Notifications
You must be signed in to change notification settings - Fork 419
[CELEBORN-1490][CIP-6] Introduce tier factory and master agent in flink hybrid shuffle #2721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
120 changes: 120 additions & 0 deletions
120
...flink-1.20/src/main/java/org/apache/celeborn/plugin/flink/tiered/CelebornTierFactory.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,120 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.celeborn.plugin.flink.tiered; | ||
|
|
||
| import java.util.List; | ||
| import java.util.concurrent.ScheduledExecutorService; | ||
|
|
||
| import org.apache.flink.configuration.Configuration; | ||
| import org.apache.flink.runtime.io.disk.BatchShuffleReadBufferPool; | ||
| import org.apache.flink.runtime.io.network.partition.hybrid.tiered.common.TieredStoragePartitionId; | ||
| import org.apache.flink.runtime.io.network.partition.hybrid.tiered.netty.TieredStorageNettyService; | ||
| import org.apache.flink.runtime.io.network.partition.hybrid.tiered.storage.TieredStorageConsumerSpec; | ||
| import org.apache.flink.runtime.io.network.partition.hybrid.tiered.storage.TieredStorageMemoryManager; | ||
| import org.apache.flink.runtime.io.network.partition.hybrid.tiered.storage.TieredStorageMemorySpec; | ||
| import org.apache.flink.runtime.io.network.partition.hybrid.tiered.storage.TieredStorageResourceRegistry; | ||
| import org.apache.flink.runtime.io.network.partition.hybrid.tiered.tier.TierConsumerAgent; | ||
| import org.apache.flink.runtime.io.network.partition.hybrid.tiered.tier.TierFactory; | ||
| import org.apache.flink.runtime.io.network.partition.hybrid.tiered.tier.TierMasterAgent; | ||
| import org.apache.flink.runtime.io.network.partition.hybrid.tiered.tier.TierProducerAgent; | ||
| import org.apache.flink.runtime.io.network.partition.hybrid.tiered.tier.TierShuffleDescriptor; | ||
| import org.apache.flink.runtime.util.ConfigurationParserUtils; | ||
|
|
||
| import org.apache.celeborn.common.CelebornConf; | ||
| import org.apache.celeborn.plugin.flink.utils.FlinkUtils; | ||
|
|
||
| /** | ||
| * The factory class of the Celeborn client, used as a tier of flink hybrid shuffle tiered storage. | ||
| */ | ||
| public class CelebornTierFactory implements TierFactory { | ||
|
|
||
| private CelebornConf conf; | ||
|
|
||
| /** | ||
| * The bytes size of a single buffer, default value is 32KB, it will be set according to the flink | ||
| * configuration in {@link CelebornTierFactory#setup}. | ||
| */ | ||
| private int bufferSizeBytes = -1; | ||
|
|
||
| /** | ||
| * The max bytes size of a single segment, it will determine how many buffer can save in a single | ||
| * segment. | ||
| */ | ||
| private static int NUM_BYTES_PER_SEGMENT = 8 * 1024 * 1024; | ||
|
|
||
| private static final String CELEBORN_TIER_NAME = CelebornTierFactory.class.getSimpleName(); | ||
|
|
||
| @Override | ||
| public void setup(Configuration configuration) { | ||
| conf = FlinkUtils.toCelebornConf(configuration); | ||
| this.bufferSizeBytes = ConfigurationParserUtils.getPageSize(configuration); | ||
| } | ||
|
|
||
| @Override | ||
| public TieredStorageMemorySpec getMasterAgentMemorySpec() { | ||
| return new TieredStorageMemorySpec(getCelebornTierName(), 0); | ||
| } | ||
|
|
||
| @Override | ||
| public TieredStorageMemorySpec getProducerAgentMemorySpec() { | ||
| return new TieredStorageMemorySpec(getCelebornTierName(), 1); | ||
| } | ||
|
|
||
| @Override | ||
| public TieredStorageMemorySpec getConsumerAgentMemorySpec() { | ||
| return new TieredStorageMemorySpec(getCelebornTierName(), 0); | ||
| } | ||
|
|
||
| @Override | ||
| public TierMasterAgent createMasterAgent( | ||
| TieredStorageResourceRegistry tieredStorageResourceRegistry) { | ||
| return new CelebornTierMasterAgent(conf); | ||
| } | ||
|
|
||
| @Override | ||
| public TierProducerAgent createProducerAgent( | ||
| int numPartitions, | ||
| int numSubpartitions, | ||
| TieredStoragePartitionId partitionId, | ||
| String dataFileBasePath, | ||
| boolean isBroadcastOnly, | ||
| TieredStorageMemoryManager storageMemoryManager, | ||
| TieredStorageNettyService nettyService, | ||
| TieredStorageResourceRegistry resourceRegistry, | ||
| BatchShuffleReadBufferPool bufferPool, | ||
| ScheduledExecutorService ioExecutor, | ||
| List<TierShuffleDescriptor> shuffleDescriptors, | ||
| int maxRequestedBuffers) { | ||
| // TODO impl this in the follow-up PR. | ||
| return null; | ||
| } | ||
|
|
||
| @Override | ||
| public TierConsumerAgent createConsumerAgent( | ||
| List<TieredStorageConsumerSpec> tieredStorageConsumerSpecs, | ||
| List<TierShuffleDescriptor> shuffleDescriptors, | ||
| TieredStorageNettyService nettyService) { | ||
| // TODO impl this in the follow-up PR. | ||
| return null; | ||
| } | ||
|
|
||
| public static String getCelebornTierName() { | ||
| return CELEBORN_TIER_NAME; | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.