[CELEBORN-1594] Refine dynamicConfig template and prevent NPE#2737
Closed
turboFei wants to merge 6 commits intoapache:mainfrom
Closed
[CELEBORN-1594] Refine dynamicConfig template and prevent NPE#2737turboFei wants to merge 6 commits intoapache:mainfrom
turboFei wants to merge 6 commits intoapache:mainfrom
Conversation
turboFei
commented
Sep 13, 2024
| # | ||
| - level: SYSTEM | ||
| config: | ||
| celeborn.worker.directMemoryRatioToPauseReceive: 0.75 |
Member
Author
There was a problem hiding this comment.
seems this config item is not dynamic, I wonder whether it works now
Member
Author
There was a problem hiding this comment.
Currently, there are only 4 dynamic configs for quota management.
Contributor
There was a problem hiding this comment.
seems this config item is not dynamic, I wonder whether it works now
yes，seems can be dynamic，but not supported yet.
Member
Author
There was a problem hiding this comment.
Raised ticket to support more dynamic configs: https://issues.apache.org/jira/browse/CELEBORN-1598
turboFei
commented
Sep 13, 2024
turboFei
changed the title
turboFei
changed the title
turboFei
force-pushed
the
dynamic_config
branch
from
87d9a54 to
096d6c3
Compare
turboFei
changed the title
turboFei
changed the title
turboFei
force-pushed
the
dynamic_config
branch
from
13da0d9 to
b863c15
Compare
RexXiong
approved these changes
Sep 14, 2024
RexXiong
pushed a commit
that referenced
this pull request
Sep 15, 2024
### What changes were proposed in this pull request? 1. seems the quota.yaml is outdated, remove it 2. the config item set in dynamicConfig.yaml.template is not dynamic config, remove the one 3. prevent NPE when loading dynamicConfig.yaml ### Why are the changes needed? As title. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing UT. Closes #2737 from turboFei/dynamic_config. Authored-by: Wang, Fei <fwang12@ebay.com> Signed-off-by: Shuang <lvshuang.xjs@alibaba-inc.com> (cherry picked from commit d335c64) Signed-off-by: Shuang <lvshuang.xjs@alibaba-inc.com>
Contributor
|
Thanks. merge to main(v0.6.0) and branch-0.5(v0.5.2) |
s0nskar
pushed a commit
to s0nskar/celeborn
that referenced
this pull request
Sep 16, 2024
### What changes were proposed in this pull request? 1. seems the quota.yaml is outdated, remove it 2. the config item set in dynamicConfig.yaml.template is not dynamic config, remove the one 3. prevent NPE when loading dynamicConfig.yaml ### Why are the changes needed? As title. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing UT. Closes apache#2737 from turboFei/dynamic_config. Authored-by: Wang, Fei <fwang12@ebay.com> Signed-off-by: Shuang <lvshuang.xjs@alibaba-inc.com>
wankunde
pushed a commit
to wankunde/celeborn
that referenced
this pull request
Oct 11, 2024
### What changes were proposed in this pull request? 1. seems the quota.yaml is outdated, remove it 2. the config item set in dynamicConfig.yaml.template is not dynamic config, remove the one 3. prevent NPE when loading dynamicConfig.yaml ### Why are the changes needed? As title. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing UT. Closes apache#2737 from turboFei/dynamic_config. Authored-by: Wang, Fei <fwang12@ebay.com> Signed-off-by: Shuang <lvshuang.xjs@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
As title.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing UT.