[CELEBORN-1603] parameterize init container image#2745
Closed
aagumin wants to merge 1 commit intoapache:mainfrom
Closed
[CELEBORN-1603] parameterize init container image#2745aagumin wants to merge 1 commit intoapache:mainfrom
aagumin wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
|
Thanks. This pr is helpful. Celeborn's most PR is connected with a Jira ticket before merging into the main. |
Contributor
Author
|
Hello! No, thanks, i sent request for creation jira account. |
FMX
changed the title
FMX
approved these changes
Sep 20, 2024
Contributor
FMX
left a comment
FMX
left a comment
There was a problem hiding this comment.
LGTM. Thanks. Merged into main(v0.6.0).
wankunde
pushed a commit
to wankunde/celeborn
that referenced
this pull request
Oct 11, 2024
### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? Closes apache#2745 from aagumin/feature/helm-chart-init-container-registry. Authored-by: Arsen Gumin <60981750+aagumin@users.noreply.github.com> Signed-off-by: mingji <fengmingxiao.fmx@alibaba-inc.com>
HolyLow
pushed a commit
to HolyLow/celeborn
that referenced
this pull request
Oct 14, 2024
### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? Closes apache#2745 from aagumin/feature/helm-chart-init-container-registry. Authored-by: Arsen Gumin <60981750+aagumin@users.noreply.github.com> Signed-off-by: mingji <fengmingxiao.fmx@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?