[CELEBORN-1609] Support SSL for celeborn RESTful service#2756
Closed
turboFei wants to merge 10 commits intoapache:mainfrom
Closed
[CELEBORN-1609] Support SSL for celeborn RESTful service#2756turboFei wants to merge 10 commits intoapache:mainfrom
turboFei wants to merge 10 commits intoapache:mainfrom
Conversation
turboFei
changed the title
Member
Author
turboFei
commented
Sep 21, 2024
| private def setCelebornOpenAPIDefinition(openApi: OpenAPI, requestBaseUri: URI): OpenAPI = { | ||
| val httpScheme = if (httpService.httpSslEnabled()) "https:" else "http:" | ||
| val requestBaseUrl = s"$httpScheme${requestBaseUri.getSchemeSpecificPart}" | ||
| val apiUrls = List(requestBaseUrl, s"$httpScheme//${httpService.connectionUrl}/").distinct |
Member
Author
There was a problem hiding this comment.
To fix the swagger request url scheme inconsistent when SSL enabled.
Member
Author
There was a problem hiding this comment.
scala> val uri = new java.net.URI("https://celeborn.vip.com:9098/")
val uri: java.net.URI = https://celeborn.vip.com:9098/
scala> uri.getSchemeSpecificPart
val res0: String = //celeborn.vip.com:9098/
scala> "https:" + uri.getSchemeSpecificPart
val res1: String = https://celeborn.vip.com:9098/
scala>
scala>
Contributor
|
Thanks. merge to main(v0.6.0) |
HolyLow
pushed a commit
to HolyLow/celeborn
that referenced
this pull request
Oct 14, 2024
### What changes were proposed in this pull request? Support SSL for celeborn RESTful service. ### Why are the changes needed? For HTTP SSL connection requirements. ### Does this PR introduce _any_ user-facing change? No, SSL is disabled by defaults. ### How was this patch tested? Integration testing. ``` celeborn.master.http.ssl.enabled=true celeborn.master.http.ssl.keystore.path=/hadoop/keystore.jks celeborn.master.http.ssl.keystore.password=xxxxxxx ``` <img width="1143" alt="image" src="https://github.com/user-attachments/assets/2334561d-1de3-4b38-bc80-5d5d86d3b8ff"> <img width="695" alt="image" src="https://github.com/user-attachments/assets/e3877468-cc3b-4a4a-bf75-2994f557a104"> Closes apache#2756 from turboFei/HADP_1609_ssl2. Authored-by: Wang, Fei <fwang12@ebay.com> Signed-off-by: Shuang <lvshuang.xjs@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support SSL for celeborn RESTful service.
Why are the changes needed?
For HTTP SSL connection requirements.
Does this PR introduce any user-facing change?
No, SSL is disabled by defaults.
How was this patch tested?
Integration testing.