[CELEBORN-914][FOLLOWUP] Add emptyFilePrimaryIds and emptyFileReplicaIds of worker service log in startup document#2774
Closed
SteNicholas wants to merge 1 commit intoapache:mainfrom
Closed
Conversation
…Ids of worker service log in startup document
Member
Author
|
Ping @FMX. |
FMX
approved these changes
Oct 8, 2024
Contributor
FMX
left a comment
FMX
left a comment
There was a problem hiding this comment.
LGTM. Thanks. Merged into main(0.6.0) and branch-0.5(v0.5.2).
FMX
pushed a commit
that referenced
this pull request
Oct 8, 2024
…Ids of worker service log in startup document ### What changes were proposed in this pull request? Add `emptyFilePrimaryIds` and `emptyFileReplicaIds` of worker service log in startup document. ### Why are the changes needed? #2300 has added `emptyFilePrimaryIds` and `emptyFileReplicaIds` of startup log of for worker service in `Controller`, which should also add into the log of startup document. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? No. Closes #2774 from SteNicholas/CELEBORN-914. Authored-by: SteNicholas <programgeek@163.com> Signed-off-by: mingji <fengmingxiao.fmx@alibaba-inc.com> (cherry picked from commit c5ff12b) Signed-off-by: mingji <fengmingxiao.fmx@alibaba-inc.com>
turboFei
pushed a commit
to turboFei/incubator-celeborn
that referenced
this pull request
Oct 10, 2024
…Ids of worker service log in startup document ### What changes were proposed in this pull request? Add `emptyFilePrimaryIds` and `emptyFileReplicaIds` of worker service log in startup document. ### Why are the changes needed? apache#2300 has added `emptyFilePrimaryIds` and `emptyFileReplicaIds` of startup log of for worker service in `Controller`, which should also add into the log of startup document. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? No. Closes apache#2774 from SteNicholas/CELEBORN-914. Authored-by: SteNicholas <programgeek@163.com> Signed-off-by: mingji <fengmingxiao.fmx@alibaba-inc.com>
HolyLow
pushed a commit
to HolyLow/celeborn
that referenced
this pull request
Oct 14, 2024
…Ids of worker service log in startup document ### What changes were proposed in this pull request? Add `emptyFilePrimaryIds` and `emptyFileReplicaIds` of worker service log in startup document. ### Why are the changes needed? apache#2300 has added `emptyFilePrimaryIds` and `emptyFileReplicaIds` of startup log of for worker service in `Controller`, which should also add into the log of startup document. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? No. Closes apache#2774 from SteNicholas/CELEBORN-914. Authored-by: SteNicholas <programgeek@163.com> Signed-off-by: mingji <fengmingxiao.fmx@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add
emptyFilePrimaryIdsandemptyFileReplicaIdsof worker service log in startup document.Why are the changes needed?
#2300 has added
emptyFilePrimaryIdsandemptyFileReplicaIdsof startup log of for worker service inController, which should also add into the log of startup document.Does this PR introduce any user-facing change?
No.
How was this patch tested?
No.