[CELEBORN-1652] Throw TransportableError for failure of sending PbReadAddCredit to avoid flink task get stuck#2811
Closed
codenohup wants to merge 1 commit into
Closed
[CELEBORN-1652] Throw TransportableError for failure of sending PbReadAddCredit to avoid flink task get stuck#2811codenohup wants to merge 1 commit into
codenohup wants to merge 1 commit into
Conversation
Contributor
|
Could you raise a jira ticket for this? |
codenohup
changed the title
codenohup
changed the title
codenohup
force-pushed
the
fix-send-credit
branch
from
aca80b1 to
920b390
Compare
Contributor
Author
SteNicholas
changed the title
SteNicholas
changed the title
SteNicholas
reviewed
Oct 15, 2024
SteNicholas
changed the title
…edit to avoid flink task get stuck
codenohup
force-pushed
the
fix-send-credit
branch
from
b6d8ad2 to
a24ba6d
Compare
SteNicholas
changed the title
RexXiong
approved these changes
Oct 15, 2024
RexXiong
pushed a commit
that referenced
this pull request
Oct 15, 2024
…dAddCredit to avoid flink task get stuck ### What changes were proposed in this pull request? Throw `TransportableError` for failure of sending `PbReadAddCredit` to avoid flink task get stuck. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? by manual verification Closes #2811 from codenohup/fix-send-credit. Authored-by: codenohup <huangxu.walker@gmail.com> Signed-off-by: Shuang <lvshuang.xjs@alibaba-inc.com> (cherry picked from commit af930e7) Signed-off-by: Shuang <lvshuang.xjs@alibaba-inc.com>
RexXiong
pushed a commit
that referenced
this pull request
Oct 15, 2024
…dAddCredit to avoid flink task get stuck ### What changes were proposed in this pull request? Throw `TransportableError` for failure of sending `PbReadAddCredit` to avoid flink task get stuck. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? by manual verification Closes #2811 from codenohup/fix-send-credit. Authored-by: codenohup <huangxu.walker@gmail.com> Signed-off-by: Shuang <lvshuang.xjs@alibaba-inc.com> (cherry picked from commit af930e7) Signed-off-by: Shuang <lvshuang.xjs@alibaba-inc.com>
Contributor
|
Thanks. merged to main(v0.6.0) and branch-0.5(v0.5.2) and branch-0.4(v0.4.3) |
zaynt4606
pushed a commit
to zaynt4606/celeborn
that referenced
this pull request
Oct 21, 2024
…dAddCredit to avoid flink task get stuck ### What changes were proposed in this pull request? Throw `TransportableError` for failure of sending `PbReadAddCredit` to avoid flink task get stuck. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? by manual verification Closes apache#2811 from codenohup/fix-send-credit. Authored-by: codenohup <huangxu.walker@gmail.com> Signed-off-by: Shuang <lvshuang.xjs@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Throw
TransportableErrorfor failure of sendingPbReadAddCreditto avoid flink task get stuck.Does this PR introduce any user-facing change?
No.
How was this patch tested?
by manual verification