[CELEBORN-1487][Phase2] CongestionController support dynamic config#2817
Closed
leixm wants to merge 4 commits into
Closed
[CELEBORN-1487][Phase2] CongestionController support dynamic config#2817leixm wants to merge 4 commits into
leixm wants to merge 4 commits into
Conversation
Contributor
Author
|
Can you help review? @RexXiong |
RexXiong
reviewed
Oct 17, 2024
| * | ||
| * @param listener the listener to be registered | ||
| */ | ||
| void registerListenerOnConfigUpdate(Consumer<ConfigService> listener); |
Contributor
There was a problem hiding this comment.
If we don't have a listener interface, perhaps using Runnable would be more suitable, as we wouldn't need to accept a ConfigService.
RexXiong
reviewed
Oct 18, 2024
| return consumedBufferStatusHub; | ||
| } | ||
|
|
||
| private void updateQuota(ConfigService configService) { |
Contributor
There was a problem hiding this comment.
nit: configService is already a member variable
RexXiong
approved these changes
Oct 18, 2024
zaynt4606
pushed a commit
to zaynt4606/celeborn
that referenced
this pull request
Oct 21, 2024
### What changes were proposed in this pull request? CongestionController support dynamic config ### Why are the changes needed? Currently, Celeborn only supports quota management based on disk file bytes/count, and this quota management cannot cope with sudden increases in traffic, which will cause corrupt to the cluster. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? UT. Closes apache#2817 from leixm/CELEBORN-1487-2. Authored-by: Xianming Lei <31424839+leixm@users.noreply.github.com> Signed-off-by: Shuang <lvshuang.xjs@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
CongestionController support dynamic config
Why are the changes needed?
Currently, Celeborn only supports quota management based on disk file bytes/count, and this quota management cannot cope with sudden increases in traffic, which will cause corrupt to the cluster.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
UT.