[CELEBORN-1657] Throw exception to client when exception occurred in reading sort shuffle files#2818
Closed
FMX wants to merge 2 commits into
Closed
[CELEBORN-1657] Throw exception to client when exception occurred in reading sort shuffle files#2818FMX wants to merge 2 commits into
FMX wants to merge 2 commits into
Conversation
RexXiong
reviewed
Oct 17, 2024
Contributor
RexXiong
left a comment
RexXiong
left a comment
There was a problem hiding this comment.
Better add an ut test for this
| logger.error( | ||
| "Sorting shuffle file for " + fileId + " " + originFilePath + " failed, detail: ", e); | ||
| sortExceptions | ||
| .computeIfAbsent(fileId, v -> JavaUtils.newConcurrentHashMap()) |
RexXiong
changed the title
mridulm
reviewed
Nov 3, 2024
|
|
||
| if (sortExceptions.containsKey(shuffleKey) | ||
| && sortExceptions.get(shuffleKey).containsKey(fileId)) { | ||
| throw sortExceptions.get(shuffleKey).get(fileId); |
Contributor
There was a problem hiding this comment.
Can there be a concurrent cleanup (which can result in NPE) here ?
If yes, we should try to make this atomic, something like:
AtomicReference<IOException> sortExceptionRef = new AtomicReference<>(null);
sortExceptions.compute(shuffleKey,(key, current) -> {
if (null != current) {
sortExceptionRef.set(current.get(fileId);
}
return current;
});
if (null != sortExceptionRef.get()) throw sortExceptionRef.get();
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
To report errors in sorting shuffle files.
Why are the changes needed?
Report errors to client as soon as possible when a shuffle file is corrupted.
Does this PR introduce any user-facing change?
NO.
How was this patch tested?
Cluster test.