[CELEBORN-1658] Add Git Commit Info and Build JDK Spec to sbt Manifest#2821
Closed
cfmcgrady wants to merge 5 commits into
Closed
[CELEBORN-1658] Add Git Commit Info and Build JDK Spec to sbt Manifest#2821cfmcgrady wants to merge 5 commits into
cfmcgrady wants to merge 5 commits into
Conversation
Member
|
How about adding the following properties? |
Contributor
Author
addressed. |
FMX
approved these changes
Oct 21, 2024
zaynt4606
pushed a commit
to zaynt4606/celeborn
that referenced
this pull request
Oct 21, 2024
### What changes were proposed in this pull request? This PR adding Git commit information and JVM build specifications to package manifest. the `META-INF/MANIFEST.MF` before this PR: ``` Manifest-Version: 1.0 Specification-Title: celeborn-client-spark-3-shaded Specification-Version: 0.6.0-SNAPSHOT Specification-Vendor: org.apache.celeborn Implementation-Title: celeborn-client-spark-3-shaded Implementation-Version: 0.6.0-SNAPSHOT Implementation-Vendor: org.apache.celeborn Implementation-Vendor-Id: org.apache.celeborn ``` after this PR: ``` Manifest-Version: 1.0 Specification-Title: celeborn-client-spark-3-shaded Specification-Version: 0.6.0-SNAPSHOT Specification-Vendor: org.apache.celeborn Implementation-Title: celeborn-client-spark-3-shaded Implementation-Version: 0.6.0-SNAPSHOT Implementation-Vendor: org.apache.celeborn Implementation-Vendor-Id: org.apache.celeborn Build-Jdk-Spec: 17.0.9 Build-Revision: 03247c1 Build-Branch: jdk-git-spec Build-Time: 2024-10-18T17:53:02.723124+08:00[Asia/Shanghai] ``` ``` Manifest-Version: 1.0 Specification-Title: celeborn-client-spark-3-shaded Specification-Version: 0.6.0-SNAPSHOT Specification-Vendor: org.apache.celeborn Implementation-Title: celeborn-client-spark-3-shaded Implementation-Version: 0.6.0-SNAPSHOT Implementation-Vendor: org.apache.celeborn Implementation-Vendor-Id: org.apache.celeborn Build-Jdk-Spec: 17.0.9 Build-Revision: N/A Build-Branch: Build-Time: 2024-10-18T17:54:16.932121+08:00[Asia/Shanghai] ``` ### Why are the changes needed? As title. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? local Closes apache#2821 from cfmcgrady/jdk-git-spec. Authored-by: Fu Chen <cfmcgrady@gmail.com> Signed-off-by: mingji <fengmingxiao.fmx@alibaba-inc.com>
cfmcgrady
added a commit
to cfmcgrady/incubator-celeborn
that referenced
this pull request
Aug 21, 2025
This PR adding Git commit information and JVM build specifications to package manifest. the `META-INF/MANIFEST.MF` before this PR: ``` Manifest-Version: 1.0 Specification-Title: celeborn-client-spark-3-shaded Specification-Version: 0.6.0-SNAPSHOT Specification-Vendor: org.apache.celeborn Implementation-Title: celeborn-client-spark-3-shaded Implementation-Version: 0.6.0-SNAPSHOT Implementation-Vendor: org.apache.celeborn Implementation-Vendor-Id: org.apache.celeborn ``` after this PR: ``` Manifest-Version: 1.0 Specification-Title: celeborn-client-spark-3-shaded Specification-Version: 0.6.0-SNAPSHOT Specification-Vendor: org.apache.celeborn Implementation-Title: celeborn-client-spark-3-shaded Implementation-Version: 0.6.0-SNAPSHOT Implementation-Vendor: org.apache.celeborn Implementation-Vendor-Id: org.apache.celeborn Build-Jdk-Spec: 17.0.9 Build-Revision: 03247c1 Build-Branch: jdk-git-spec Build-Time: 2024-10-18T17:53:02.723124+08:00[Asia/Shanghai] ``` ``` Manifest-Version: 1.0 Specification-Title: celeborn-client-spark-3-shaded Specification-Version: 0.6.0-SNAPSHOT Specification-Vendor: org.apache.celeborn Implementation-Title: celeborn-client-spark-3-shaded Implementation-Version: 0.6.0-SNAPSHOT Implementation-Vendor: org.apache.celeborn Implementation-Vendor-Id: org.apache.celeborn Build-Jdk-Spec: 17.0.9 Build-Revision: N/A Build-Branch: Build-Time: 2024-10-18T17:54:16.932121+08:00[Asia/Shanghai] ``` As title. No local Closes apache#2821 from cfmcgrady/jdk-git-spec. Authored-by: Fu Chen <cfmcgrady@gmail.com> Signed-off-by: mingji <fengmingxiao.fmx@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adding Git commit information and JVM build specifications to package manifest.
the
META-INF/MANIFEST.MFbefore this PR:after this PR:
Why are the changes needed?
As title.
Does this PR introduce any user-facing change?
No
How was this patch tested?
local